Clean-up and take advantage of newer .NET APIs. #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
May 6, 2025
| try | ||
| { | ||
| Offsets = (ulong*)Marshal.AllocHGlobal(strings.Count * sizeof(ulong)); | ||
| Offsets = (ulong*)NativeMemory.Alloc((nuint)strings.Count, sizeof(ulong)); |
Member
Author
There was a problem hiding this comment.
For historical reasons, Marshal.AllocHGlobal uses a legacy and slower API on Windows to allocate memory. NativeMemory.Alloc was introduced more recently and is documented to always call malloc while also featuring slightly improved ergonomics.
Member
Author
|
/gemini review |
shaunrd0
approved these changes
May 8, 2025
| /// been registered with <paramref name="name"/>.</exception> | ||
| public ulong GetResultValidities(string name) => _handle.GetResultValidities(name); | ||
|
|
||
| private sealed class BufferHandle : IDisposable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-65510
Now that we target .NET 8, this PR makes use of some APIs added after .NET 5, and cleans up some adjacent code.