Feature/client permissions enum #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannicklamprecht
suggested changes
Mar 9, 2023
| @@ -1002,9 +1048,6 @@ public void deleteChannelGroup(int groupId, boolean force) { | |||
| * @see ChannelGroup#getId() | |||
| * @see Permission#getName() | |||
| */ | |||
| public void deleteChannelGroupPermission(int groupId, String permName) { | |||
There was a problem hiding this comment.
Would instead deprecate the method and describe what to use instead. Delegate the call in an adapted way to the new method.
Just deleting a method is a breaking change.
There was a problem hiding this comment.
I didn't pay attention, it's a mistake on my part to have deleted this method. I will correct it.
yannicklamprecht
approved these changes
Mar 9, 2023
|
Hi @RMrenex! Amazing work, merged! Thank you for contributing this to the API 😄 @yannicklamprecht thanks for the review and for spotting the breaking change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had proposed at one time to add enum for adding and removing permissions to facilitate the use of the api. Here is the first part which concerns only the client part. I'll do the others next time :)