-
Notifications
You must be signed in to change notification settings - Fork 29
Release bevy_lint
v0.2.0
#308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall polishGenerally impressed! The README and so on are in good shape. Needing such a cursed setup to run this sucks a lot, but rust-lang/rust#138586 should eventually help. New lintsborrowed_reborrowable: niche but very reasonable. Hard to discover without the lint! duplicate_bevy_dependencies: absolutely vital. Could use a bit more explanation about how this works, and should probably point to cargo-deny as a "see more" sort of tool. insert_unit_bundle: sure! I mean, I guess? This seems rare, but might as well spot it and warn. Blog notes
This needs more explanation to explain to casual readers why it's Very Bad. IMO you should move the "fixed on Windows" section to the third bullet point: most readers aren't using this tool yet! Overall solid though. AssortedThe lint list over at https://thebevyflock.github.io/bevy_cli/bevy_lint/lints/index.html is a bit weird, because of the It would be really nice to be able to quickly tell a) which lints are associated with each level b) the list of lints for each level. Maybe use traits and Bevy's shiny new trait tagging HTML? Verdict
Then, ship it 🚀 |
Make `duplicate_bevy_dependencies` appear to be "just another lint", and make `cargo` private.
There's still a few more things I want to improve! I'll merge this once I'm happy with it :) |
As per the release checklist, this PR kicks off the release of
bevy_lint
v0.2.0.Links
Release Process
In order for v0.2.0 to be released, we need the approval of at least one Bevy maintainer and no outstanding questions / issues. Now's your chance to test the linter in its current state and make sure you're happy with it!