Skip to content

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Mar 13, 2025

As per the release checklist, this PR kicks off the release of bevy_lint v0.2.0.

Links

Release Process

In order for v0.2.0 to be released, we need the approval of at least one Bevy maintainer and no outstanding questions / issues. Now's your chance to test the linter in its current state and make sure you're happy with it!

@BD103 BD103 added A-Linter Related to the linter and custom lints S-Needs-Review The PR needs to be reviewed before it can be merged labels Mar 13, 2025
@BD103 BD103 added this to the `bevy_lint` v0.2.0 milestone Mar 13, 2025
@alice-i-cecile alice-i-cecile self-requested a review March 18, 2025 17:08
@alice-i-cecile
Copy link
Member

Overall polish

Generally impressed! The README and so on are in good shape.

Needing such a cursed setup to run this sucks a lot, but rust-lang/rust#138586 should eventually help.

New lints

borrowed_reborrowable: niche but very reasonable. Hard to discover without the lint!

duplicate_bevy_dependencies: absolutely vital. Could use a bit more explanation about how this works, and should probably point to cargo-deny as a "see more" sort of tool.

insert_unit_bundle: sure! I mean, I guess? This seems rare, but might as well spot it and warn.

Blog notes

Finally, duplicate_bevy_dependencies checks if your depending on multiple major versions of Bevy in the same crate:

This needs more explanation to explain to casual readers why it's Very Bad.

IMO you should move the "fixed on Windows" section to the third bullet point: most readers aren't using this tool yet!

Overall solid though.

Assorted

The lint list over at https://thebevyflock.github.io/bevy_cli/bevy_lint/lints/index.html is a bit weird, because of the cargo module. This is inconsistent with the other lints: I don't think that this division should be user visible.

It would be really nice to be able to quickly tell a) which lints are associated with each level b) the list of lints for each level. Maybe use traits and Bevy's shiny new trait tagging HTML?

Verdict

  • Polish up the duplicate_bevy_dependencies docs
  • Make the organization fro duplicate_bevy_dependencies consistent with the other lints

Then, ship it 🚀

@BD103 BD103 added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review The PR needs to be reviewed before it can be merged labels Mar 18, 2025
@alice-i-cecile alice-i-cecile removed the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Mar 18, 2025
@BD103 BD103 added the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Mar 18, 2025
@BD103
Copy link
Member Author

BD103 commented Mar 18, 2025

There's still a few more things I want to improve! I'll merge this once I'm happy with it :)

@BD103 BD103 removed the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Mar 19, 2025
@BD103 BD103 enabled auto-merge (squash) March 19, 2025 15:05
@BD103 BD103 disabled auto-merge March 19, 2025 15:06
@BD103 BD103 enabled auto-merge (squash) March 19, 2025 15:06
@BD103 BD103 merged commit b5012ec into main Mar 19, 2025
10 checks passed
@BD103 BD103 deleted the linter-v0.2.0 branch March 19, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Related to the linter and custom lints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants