Skip to content

Force rustup to add rustc_driver.dll to the PATH #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Force rustup to add rustc_driver.dll to the PATH #281

merged 1 commit into from
Feb 24, 2025

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Feb 24, 2025

Fixes #267! For more context, see this comment:

I found the issue! Due to rust-lang/rustup#3703, Rustup no longer modifies the PATH on Windows because it prevented sub-invocations of cargo and rustc from going through their proxy. There was a call for testing related to this, but it was announced before the linter was ever created. Because I don't use Windows frequently, I never caught the issue.

We can fix this by setting RUSTUP_WINDOWS_PATH_ADD_BIN=1:

> set RUSTUP_WINDOWS_PATH_ADD_BIN=1
> rustup run nightly-2025-01-09 .\bevy_lint.exe

@BD103 BD103 added A-Linter Related to the linter and custom lints C-Bug A bug in the program S-Needs-Review The PR needs to be reviewed before it can be merged labels Feb 24, 2025
@BD103 BD103 mentioned this pull request Feb 24, 2025
Closed
DaAlbrecht
DaAlbrecht approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@DaAlbrecht DaAlbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so glad this fixes it ^^

@DaAlbrecht DaAlbrecht merged commit 9292db9 into main Feb 24, 2025
8 checks passed
@DaAlbrecht DaAlbrecht deleted the fix-windows-path branch February 24, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaAlbrecht DaAlbrecht DaAlbrecht approved these changes

Assignees
No one assigned
Labels
A-Linter Related to the linter and custom lints C-Bug A bug in the program S-Needs-Review The PR needs to be reviewed before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustc_driver.dll not found on Windows
2 participants
@BD103 @DaAlbrecht