Skip to content

fix bug in void Geometry::GetCenterExtents(glm::dvec3& center, glm::d… #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix bug in void Geometry::GetCenterExtents(glm::dvec3& center, glm::d… #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
097faa6
fix bug in void Geometry::GetCenterExtents(glm::dvec3& center, glm::d…
ifcapps May 5, 2025
1d830e7
update regression/results.json
ifcapps May 13, 2025
78eea12
update regression/results.json
ifcapps May 13, 2025
b3a1f8f
update results.json after npm update
ifcapps May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cpp/web-ifc/geometry/representation/IfcGeometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ namespace webifc::geometry {
void Geometry::GetCenterExtents(glm::dvec3& center, glm::dvec3& extents) const
{
glm::dvec3 min(DBL_MAX, DBL_MAX, DBL_MAX);
glm::dvec3 max(DBL_MIN, DBL_MIN, DBL_MIN);
glm::dvec3 max(-DBL_MAX, -DBL_MAX, -DBL_MAX);

for (size_t i = 0; i < numPoints; i++)
{
Expand Down
2 changes: 1 addition & 1 deletion tests/regression/results.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"tests/ifcfiles/public/AC20-FZK-Haus.ifc":"ddbc072479c7d36c704a511816d277d42d5f11856475a8e13569ef3e54d57862","tests/ifcfiles/public/C20-Institute-Var-2.ifc":"84d23a1a3f4bbdc53cee769fe1a48d860eb8d53a11c74924d0b8aca8d5476f26","tests/ifcfiles/public/FM_ARC_DigitalHub.ifc":"4d05247c5ace2bd554ba639e3dd636643de6e1e6ccbdde896c33e6512b940fbc","tests/ifcfiles/public/ISSUE_005_haus.ifc":"ddbc072479c7d36c704a511816d277d42d5f11856475a8e13569ef3e54d57862","tests/ifcfiles/public/ISSUE_021_Mini Project.ifc":"aaa41aaf49e4347f533ee8a8c6b70f4c821a69784e3deddb2f342045319424b0","tests/ifcfiles/public/ISSUE_034_HouseZ.ifc":"38a9e8ff28a3703018dadda2b9af55953c5421d768a85f421792be8c9dc0aa2a","tests/ifcfiles/public/ISSUE_044_test_IFCCOMPOSITEPROFILEDEF.ifc":"c00b1a1495a76def126ce4e233084589f51982fbd274fccb3a49c7a28535602a","tests/ifcfiles/public/ISSUE_053_20181220Holter_Tower_10.ifczip":"80c14b20355d6be8598035cdd834a7161972600e85108b7e719e9cc32e064676","tests/ifcfiles/public/ISSUE_068_ARK_NUS_skolebygg.ifc":"c5547962bb01a63518943a1ac80d29fbbb58e3981c604a2690cca7f3798ab918","tests/ifcfiles/public/ISSUE_102_M3D-CON-CD.ifc":"3aa0563cd8d42b912c028f2366ac0eb858401f121b024fa1492900524df8c1e9","tests/ifcfiles/public/ISSUE_102_M3D-CON.ifc":"5ff99be059d4ef39dc8c1ff481db2d2f2c22608b0312bff1afb77c88ca3ad591","tests/ifcfiles/public/ISSUE_126_model.ifc":"ac346eadff1eb32f65c46fa5d079e26731bd3e7e002783aaf5f6563a8c3b8fac","tests/ifcfiles/public/ISSUE_129_N1540_17_EXE_MOD_448200_02_09_11SMC_IGC_V17.ifc":"b99a204ba4506ce03621df3312865b7f61e594d76555e9b3bf3737c0bf6eaa8f","tests/ifcfiles/public/ISSUE_159_kleine_Wohnung_R22.ifc":"e4fed6ffed535fa2d7a37d1d20ea72bb28cd79eeba4943cbe3c5a47af10df480","tests/ifcfiles/public/ISSUE_171_IfcSurfaceCurveSweptAreaSolid.ifc":"0c8ed6afc3e7cf9a8d1b0512bd08b71d58d31105e012a0870243c0af829c5136","tests/ifcfiles/public/IfcOpenHouse_IFC4.ifc":"f6ea0ab3e381f6f1fd7f7090671a01cd33e30f789f7f1726721c67773ce030c6","tests/ifcfiles/public/KIT-Simple-Road-Test-Web-IFC4x3_RC2.ifc":"40e80188f399629289c7f1c8eb85354cd934965b95d7b85cad8d317c9059e25d","tests/ifcfiles/public/Office_A_20110811.ifc":"239af8e0c81dc58237290a05fed141497c1984d947fb468eee926e2477577123","tests/ifcfiles/public/S_Office_Integrated Design Archi.ifc":"b068507a9f42d5af91602ebbcf0e3f22bb2dab9cd3815425a5e01682c4201c3b","tests/ifcfiles/public/Sample_entities.ifc":"6103f60e8c998be307700e25705a7c7cd32aabb33227e4d2680cb37d76619d5f","tests/ifcfiles/public/advanced_model.ifc":"a6d1757016a16e62d8b081cc21860e0f508cdf1ea8e99696dbe2f1a789cedf86","tests/ifcfiles/public/dental_clinic.ifc":"cb3c048989870bcf8cea0763a50860eb804d99dfbbbafeee613491a4275a1876","tests/ifcfiles/public/duplex.ifc":"d851c33e73c05abeb2bb025ae2557d04338658aaeb74370a641e0f4ee63befbc","tests/ifcfiles/public/example.ifc":"dbe17b9adc264086cebd8de862f0b065ad574a014dca7a3973e93b1fef4430b1","tests/ifcfiles/public/ifcbridge-model01.ifc":"75fb287b92c5935ee3d2c1a0fd0c4a597fc6d21aa7445e39b2b8ce5c972f2a31","tests/ifcfiles/public/schependomlaan.ifc":"2259466c4fad90a85c3322d1a4154d06c2eb9041d6e3f97949939653a8e99838","tests/ifcfiles/public/tested_sample_project.ifc":"7f4177f29381300110864c4db0af1ec1ff5b5ffede21591e1eaeeb07f942bd3d"}
{"tests/ifcfiles/public/AC20-FZK-Haus.ifc":"617d5340d457ad354df453306d9c515afdec9544ac7e721158df1a435f1cd680","tests/ifcfiles/public/C20-Institute-Var-2.ifc":"c0212b61538b008e0d1b9094f2797de9968cf934a0c46f3c52eb065308a8fc92","tests/ifcfiles/public/FM_ARC_DigitalHub.ifc":"63826f942d9487d43f32c36a396e7c0915e3c2168434283284eac99288f237f8","tests/ifcfiles/public/ISSUE_005_haus.ifc":"617d5340d457ad354df453306d9c515afdec9544ac7e721158df1a435f1cd680","tests/ifcfiles/public/ISSUE_021_Mini Project.ifc":"aaa41aaf49e4347f533ee8a8c6b70f4c821a69784e3deddb2f342045319424b0","tests/ifcfiles/public/ISSUE_034_HouseZ.ifc":"38a9e8ff28a3703018dadda2b9af55953c5421d768a85f421792be8c9dc0aa2a","tests/ifcfiles/public/ISSUE_044_test_IFCCOMPOSITEPROFILEDEF.ifc":"5381fdb46441f4ae687cbc804b2a110d63201f84008267bf5ba8309f8ee1767a","tests/ifcfiles/public/ISSUE_053_20181220Holter_Tower_10.ifczip":"c07835d4ffc0f78ca40d7f59b82087883f0fd95c84c88295ac0d334e00b70c01","tests/ifcfiles/public/ISSUE_068_ARK_NUS_skolebygg.ifc":"045dc5f11fff0f50c03d5528498f3d8836852f5ce1e52e6adf2c5820e6755baf","tests/ifcfiles/public/ISSUE_102_M3D-CON-CD.ifc":"cd73670a892aecc16c270d4422b5220d37b0701a1a9e12edb74c71c4137c1ec4","tests/ifcfiles/public/ISSUE_102_M3D-CON.ifc":"0bd580034d482232b7f3bc6a33988651e2b83411d46ea943955133e038ecc5e8","tests/ifcfiles/public/ISSUE_126_model.ifc":"ac346eadff1eb32f65c46fa5d079e26731bd3e7e002783aaf5f6563a8c3b8fac","tests/ifcfiles/public/ISSUE_129_N1540_17_EXE_MOD_448200_02_09_11SMC_IGC_V17.ifc":"91a4160d96d1cf9a247a9ffe122dac2558ca609ff56fc5fabc98c5017e566701","tests/ifcfiles/public/ISSUE_159_kleine_Wohnung_R22.ifc":"0fcb3d913c5276dbfaf6930ff3b26521f33479d8c9c1fbc326cdda101a19f3d6","tests/ifcfiles/public/ISSUE_171_IfcSurfaceCurveSweptAreaSolid.ifc":"4824f43b833fdb0baaf4a121aef48fe0e33f627b77bf52c2e8f9f34f29a3ba93","tests/ifcfiles/public/IfcOpenHouse_IFC4.ifc":"ed3ef8052e0b07d4409ce20b7f83323d3cfc33e2a587477ec1358c621459479f","tests/ifcfiles/public/KIT-Simple-Road-Test-Web-IFC4x3_RC2.ifc":"40e80188f399629289c7f1c8eb85354cd934965b95d7b85cad8d317c9059e25d","tests/ifcfiles/public/Office_A_20110811.ifc":"3f39606ce675038f24d8914ac78aeff24c72821d5fc4636d1c4ef1092527fd92","tests/ifcfiles/public/S_Office_Integrated Design Archi.ifc":"97c90d90c614e8f9494bf7475954fa2abb0faec17b348ef61d25ef6284e9f19f","tests/ifcfiles/public/Sample_entities.ifc":"6103f60e8c998be307700e25705a7c7cd32aabb33227e4d2680cb37d76619d5f","tests/ifcfiles/public/advanced_model.ifc":"8b0946ab579f1bfc0d5106e02f5dea1f42ac616bcd598fa9d7dcb7fa242d9efd","tests/ifcfiles/public/dental_clinic.ifc":"68a45c75bbe16668df728033c152ea39b3c74ff6acabb97c2f32920b0d223ec4","tests/ifcfiles/public/duplex.ifc":"eb3a5ab113064fd5d2ce7e84007f694b6c286b7ebe3984095b9a4e08d3e1867c","tests/ifcfiles/public/example.ifc":"dbe17b9adc264086cebd8de862f0b065ad574a014dca7a3973e93b1fef4430b1","tests/ifcfiles/public/ifcbridge-model01.ifc":"75fb287b92c5935ee3d2c1a0fd0c4a597fc6d21aa7445e39b2b8ce5c972f2a31","tests/ifcfiles/public/schependomlaan.ifc":"4f6735c06adb9240c3ab1fa3fbcd558b5016ab8bd8fc091e257345e102cc08e0","tests/ifcfiles/public/tested_sample_project.ifc":"adccbc1fdb2a5f0b8cc06f26ffdf921b93eedc7d1ba15c2f813266df150b904a"}
Loading