Skip to content

Conversation

@TomJGooding
Copy link
Contributor

Fix the documentation search not working after a recent Read the Docs upgrade.

This adds sphinx_rtd_theme to the extensions as recommended in the install guide: https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html

Fixes: #3697

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Fix the documentation search not working after a recent Read the Docs
upgrade.

This adds `sphinx_rtd_theme` to the extensions as recommended in the
install guide: https://sphinx-rtd-theme.readthedocs.io/en/stable/installing.html

Fixes: Textualize#3697
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (225cb07) to head (a648cdc).
Report is 30 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3698      +/-   ##
==========================================
- Coverage   98.24%   97.98%   -0.27%     
==========================================
  Files          74       74              
  Lines        8105     8142      +37     
==========================================
+ Hits         7963     7978      +15     
- Misses        142      164      +22     
Flag Coverage Δ
unittests 97.98% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willmcgugan
Copy link
Member

Thanks

@willmcgugan willmcgugan merged commit 6396050 into Textualize:master May 2, 2025
20 checks passed
@TomJGooding TomJGooding deleted the docs-fix-search-not-working branch May 8, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Readthedocs search does not work anymore

3 participants