vulkan weight allocator prefer host memory fusion - #6545
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6545 +/- ##
==========================================
+ Coverage 93.18% 93.22% +0.03%
==========================================
Files 847 847
Lines 266764 266744 -20
==========================================
+ Hits 248591 248661 +70
+ Misses 18173 18083 -90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR consolidates Vulkan “weights in host memory” handling by folding the former VkHostAllocator behavior into VkWeightAllocator, and wiring Net::load_model() to select host-memory preference via a flag rather than switching allocator classes.
Changes:
- Update
Net::load_model()to constructVkWeightAllocatorwith a host-memory preference flag. - Extend
VkWeightAllocatorto optionally allocate/import host-backed memory (and add cleanup for host pointers). - Remove the exported
VkHostAllocatorclass from the public allocator header and implementation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/net.cpp |
Switch allocator creation to a single VkWeightAllocator with host-memory preference. |
src/allocator.h |
Change VkWeightAllocator constructor signature; remove VkHostAllocator declaration. |
src/allocator.cpp |
Implement host-memory preference inside VkWeightAllocator; delete VkHostAllocator implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.