pnnx fix sanitize op from convert.py - #6379
Merged
Merged
Conversation
Member
|
|
|
The binary size change of libncnn.so (bytes)
|
Sanitize file names by replacing dashes with underscores.
Member
|
Because pnnx automatically renames xxx-pnnx.py to xxx_pnnx.py to ensure it can be imported in Python code, I've modified it to keep the folder name part and only replace the hyphens in the .py filename. |
nihui
approved these changes
Oct 31, 2025
Member
|
Thanks for your contribution ! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: preserve hyphens in export paths
-from output paths (breaks valid dirs/files).Repro
Impact
Tests
tmpdir/"my-model-v1.2"and assert outputs exist in that exact dir.Notes