Skip to content

Fix BOF in the last channel handling logic of SSE ShuffleChannel #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nihui merged 8 commits into from
May 9, 2026
Merged

Fix BOF in the last channel handling logic of SSE ShuffleChannel #5735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c42ea73
fix: prevent BOF #5734 in the last channel handling
junwha Oct 14, 2024
e088861
Unroll the loop
junwha Mar 30, 2025
9021fb7
Remove non-critical bound check for 8/16-bits operations
junwha Mar 30, 2025
ed931df
Merge branch 'master' into fix-bof
junwha Mar 30, 2025
355b916
apply code-format changes
junwha Mar 30, 2025
554036e
Merge branch 'master' into fix-bof
nihui May 8, 2026
92047f0
Merge branch 'master' into fix-bof
nihui May 9, 2026
0d663ae
test++
nihui May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/layer/arm/shufflechannel_arm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ int ShuffleChannel_arm::forward(const Mat& bottom_blob, Mat& top_blob, const Opt

ptr1 += 2;

for (int i = 0; i < size; i++)
for (int i = 0; i < size - 1; i++)
{
float32x4_t _p0 = vld1q_f32(ptr0);
float32x4_t _p1 = vld1q_f32(ptr1);
Expand All @@ -119,6 +119,16 @@ int ShuffleChannel_arm::forward(const Mat& bottom_blob, Mat& top_blob, const Opt
ptr1 += 4;
outptr0 += 4;
}

{
outptr0[0] = ptr0[0];
outptr0[1] = ptr1[0];
outptr0[2] = ptr0[1];
outptr0[3] = ptr1[1];
ptr0 += 2;
ptr1 += 2;
outptr0 += 4;
}
}

return 0;
Expand Down Expand Up @@ -587,7 +597,7 @@ int ShuffleChannel_arm::forward_bf16s_fp16s(const Mat& bottom_blob, Mat& top_blo

ptr1 += 2;

for (int i = 0; i < size; i++)
for (int i = 0; i < size - 1; i++)
{
uint16x4_t _p0 = vld1_u16(ptr0);
uint16x4_t _p1 = vld1_u16(ptr1);
Expand All @@ -600,6 +610,16 @@ int ShuffleChannel_arm::forward_bf16s_fp16s(const Mat& bottom_blob, Mat& top_blo
ptr1 += 4;
outptr0 += 4;
}

{
outptr0[0] = ptr0[0];
outptr0[1] = ptr1[0];
outptr0[2] = ptr0[1];
outptr0[3] = ptr1[1];
ptr0 += 2;
ptr1 += 2;
outptr0 += 4;
}
}

return 0;
Expand Down
12 changes: 11 additions & 1 deletion src/layer/x86/shufflechannel_x86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ int ShuffleChannel_x86::forward(const Mat& bottom_blob, Mat& top_blob, const Opt

ptr1 += 2;

for (int i = 0; i < size; i++)
for (int i = 0; i < size - 1; i++)
{
__m128 _p0 = _mm_loadu_ps(ptr0);
__m128 _p1 = _mm_loadu_ps(ptr1);
Expand All @@ -610,6 +610,16 @@ int ShuffleChannel_x86::forward(const Mat& bottom_blob, Mat& top_blob, const Opt
ptr1 += 4;
outptr += 4;
}

{
outptr[0] = ptr0[0];
outptr[1] = ptr1[0];
outptr[2] = ptr0[1];
outptr[3] = ptr1[1];
ptr0 += 2;
ptr1 += 2;
outptr += 4;
}
}

return 0;
Expand Down
2 changes: 2 additions & 0 deletions tests/test_shufflechannel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ static int test_shufflechannel_0()
|| test_shufflechannel(5, 7, 16, 2, 0)
|| test_shufflechannel(5, 9, 16, 4, 0)
|| test_shufflechannel(3, 7, 16, 8, 0)
|| test_shufflechannel(1, 1, 20, 2, 0)
|| test_shufflechannel(5, 7, 20, 2, 0)
|| test_shufflechannel(5, 7, 24, 2, 0)
|| test_shufflechannel(3, 7, 24, 3, 0)
Expand All @@ -63,6 +64,7 @@ static int test_shufflechannel_1()
|| test_shufflechannel(5, 7, 16, 2, 1)
|| test_shufflechannel(5, 9, 16, 4, 1)
|| test_shufflechannel(3, 7, 16, 8, 1)
|| test_shufflechannel(1, 1, 20, 10, 1)
|| test_shufflechannel(5, 7, 20, 2, 1)
|| test_shufflechannel(5, 7, 24, 2, 1)
|| test_shufflechannel(3, 7, 24, 3, 1)
Expand Down
Loading