Fixed compile warnings for gcc linux build. [-Wunused-parameter] [-Wunused-but-set-variable] - #2198
Merged
Conversation
…nused-but-set-variable]
Codecov Report
@@ Coverage Diff @@
## master #2198 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 511 511
Lines 83225 83223 -2
=======================================
- Hits 71972 71971 -1
+ Misses 11253 11252 -1
Continue to review full report at Codecov.
|
Member
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2198 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 511 511
Lines 83225 83223 -2
=======================================
- Hits 71972 71971 -1
+ Misses 11253 11252 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, NCNN Team.
I fixed 2 small compile warnings for gcc linux build:
https://github.com/Tencent/ncnn/runs/1239480361?check_suite_focus=true
Could you verify and accept my PR, pls?
/home/runner/work/ncnn/ncnn/src/c_api.cpp:161:54: warning: unused parameter ‘opt’ [-Wunused-parameter]
int ncnn_option_get_use_vulkan_compute(ncnn_option_t opt)
^~~
/home/runner/work/ncnn/ncnn/src/layer/interp.cpp: In member function ‘virtual int ncnn::Interp::forward(const ncnn::Mat&, ncnn::Mat&, const ncnn::Option&) const’:
/home/runner/work/ncnn/ncnn/src/layer/interp.cpp:411:9: warning: variable ‘channels’ set but not used [-Wunused-but-set-variable]
int channels = bottom_blob.c;
^~~~~~~~