Skip to content

Fixed compile warnings for gcc linux build. [-Wunused-parameter] [-Wunused-but-set-variable] - #2198

Merged
nihui merged 1 commit into
Tencent:masterfrom
proydakov:fixed-gcc-linux-compile-warnings-unused-parameter-unused-but-set-variable
Oct 12, 2020
Merged

Fixed compile warnings for gcc linux build. [-Wunused-parameter] [-Wunused-but-set-variable]#2198
nihui merged 1 commit into
Tencent:masterfrom
proydakov:fixed-gcc-linux-compile-warnings-unused-parameter-unused-but-set-variable

Conversation

@proydakov

Copy link
Copy Markdown
Contributor

Hi, NCNN Team.

I fixed 2 small compile warnings for gcc linux build:

https://github.com/Tencent/ncnn/runs/1239480361?check_suite_focus=true

Could you verify and accept my PR, pls?

/home/runner/work/ncnn/ncnn/src/c_api.cpp:161:54: warning: unused parameter ‘opt’ [-Wunused-parameter]
int ncnn_option_get_use_vulkan_compute(ncnn_option_t opt)
^~~

/home/runner/work/ncnn/ncnn/src/layer/interp.cpp: In member function ‘virtual int ncnn::Interp::forward(const ncnn::Mat&, ncnn::Mat&, const ncnn::Option&) const’:
/home/runner/work/ncnn/ncnn/src/layer/interp.cpp:411:9: warning: variable ‘channels’ set but not used [-Wunused-but-set-variable]
int channels = bottom_blob.c;
^~~~~~~~

@codecov-io

codecov-io commented Oct 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2198 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2198   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         511      511           
  Lines       83225    83223    -2     
=======================================
- Hits        71972    71971    -1     
+ Misses      11253    11252    -1     
Impacted Files Coverage Δ
src/layer/interp.cpp 96.62% <ø> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be3f07...1cc93ed. Read the comment docs.

@nihui
nihui merged commit bc24712 into Tencent:master Oct 12, 2020
@nihui

nihui commented Oct 12, 2020

Copy link
Copy Markdown
Member

Thanks!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.47%. Comparing base (9be3f07) to head (1cc93ed).
⚠️ Report is 1880 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2198   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         511      511           
  Lines       83225    83223    -2     
=======================================
- Hits        71972    71971    -1     
+ Misses      11253    11252    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants