-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: Refine wording in external data loading guide #5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation-only edits to the React Router external data loading guide: grammar correction in loader guidance and tone adjustments in error-handling text for TanStack Query. No code examples or APIs changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
View your CI Pipeline Execution ↗ for commit e649237
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/router/framework/react/guide/external-data-loading.md (2)
37-37
: Tighten grammar and article usage; prefer “inside” to “inside of”.Improves readability and fixes minor grammar without changing meaning.
-The easiest way to integrate external caching/data library into Router is to use `route.loader`s to ensure that the data required inside of a route has been loaded and is ready to be displayed. +The easiest way to integrate an external caching or data library into the Router is to use route `loader`s to ensure the data required inside a route is loaded and ready to display.
105-105
: Reduce repetition (“again”), align terminology with React Suspense, and tighten phrasing.Keeps intent intact while eliminating redundancy and improving consistency.
-When an error occurs while using `suspense` with `TanStack Query`, you need to let queries know that you want to try again when re-rendering. This can be done by using the `reset` function provided by the `useQueryErrorResetBoundary` hook. You can invoke this function in an effect as soon as the error component mounts. This will make sure that the query is reset and will try to fetch data again when the route component is rendered again. This will also cover cases where users navigate away from the route instead of clicking the `retry` button. +When an error occurs while using React Suspense with TanStack Query, you need to signal that queries should retry on the next render. Use the `reset` function from `useQueryErrorResetBoundary` and call it in an effect when the error component mounts. This resets the query so it refetches on re-render and also covers cases where users navigate away from the route instead of clicking the `retry` button.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/router/framework/react/guide/external-data-loading.md
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/router/framework/react/guide/external-data-loading.md
[grammar] ~37-~37: There might be a mistake here.
Context: ...sure data is loaded The easiest way to integrate external caching/data library into Rout...
(QB_NEW_EN)
[style] ~37-~37: This phrase is redundant. Consider using “inside”.
Context: ...ader`s to ensure that the data required inside of a route has been loaded and is ready to...
(OUTSIDE_OF)
[style] ~105-~105: This sentence contains multiple usages of the word “again”. Consider removing or replacing it.
Context: ...in when the route component is rendered again. This will also cover cases where users...
(REPETITION_OF_AGAIN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Preview
Summary by CodeRabbit