Skip to content

fix: do not pre-decodeURI before passing to createMemoryHistory #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

fix: do not pre-decodeURI before passing to createMemoryHistory #4893

merged 1 commit into from
Aug 8, 2025

Conversation

tannerlinsley
Copy link
Collaborator

@tannerlinsley tannerlinsley commented Aug 8, 2025 •
edited by schiller-manuel
Loading

fixes #4514

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0ce1332

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m 10s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-08 21:08:27 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 8, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4893

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4893

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4893

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4893

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4893

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4893

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4893

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4893

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4893

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4893

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4893

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4893

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4893

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4893

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4893

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4893

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4893

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4893

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4893

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4893

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4893

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4893

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4893

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4893

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4893

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4893

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4893

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4893

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4893

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4893

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4893

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4893

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@4893

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4893

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4893

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4893

commit: 0ce1332

@tannerlinsley tannerlinsley merged commit e755316 into main Aug 8, 2025
5 checks passed
@tannerlinsley tannerlinsley deleted the fix/start-redirect-bug-from-decodeURI branch August 8, 2025 21:36
schiller-manuel added a commit that referenced this pull request Aug 8, 2025
@schiller-manuel
Revert "fix: do not pre-decodeURI before passing to createMemoryHisto…
af0cd98 
…ry (#4893)"

This reverts commit e755316.
tannerlinsley pushed a commit that referenced this pull request Aug 26, 2025
@schiller-manuel @tannerlinsley
Revert "fix: do not pre-decodeURI before passing to createMemoryHisto…
3ce56d7 
…ry (#4893)"

This reverts commit e755316.
tannerlinsley added a commit that referenced this pull request Aug 26, 2025
@tannerlinsley
Revert "Revert "fix: do not pre-decodeURI before passing to createMem…
7c40453 
…oryHistory (#4893)""

This reverts commit af0cd98.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schiller-manuel schiller-manuel Awaiting requested review from schiller-manuel

Assignees
No one assigned
Labels
package: react-router package: router-core package: solid-router package: start-server-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Start] Encoded URL params cause redirect loop on page refresh
1 participant
@tannerlinsley