-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(start-server-core): properly merge middleware context objects #4665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit 6233165
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test in e2e/react-start/server-functions
.
Name it "merge-server-fn-middleware-context".
added E2E testing! |
sorry but this is not a server-function related issue. |
Yup, Manuel's change makes sense 👍🏼 |
Thanks for the feedback! I've created new server-routes e2e projects for both React Start and Solid Start by duplicating the existing server-functions projects, removing the server-functions specific tests, and adding the middleware context merging test. The test has been moved from the server-functions spec to the new server-routes specs. |
Hi we just pushed a change in how ports are determined for the e2e tests. in your new tests please add an await in front of the derive port call in playwright.config.ts export const PORT = await derivePort(packageJson.name)
const baseURL = `http://localhost:${PORT}` |
Thanks for your help! |
fix #4661