Skip to content

Conversation

jamongsalguclub
Copy link
Contributor

fix #4661

Copy link

nx-cloud bot commented Jul 16, 2025

View your CI Pipeline Execution ↗ for commit 6233165

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 1m 32s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-17 07:25:49 UTC

Copy link

pkg-pr-new bot commented Jul 16, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4665

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4665

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4665

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4665

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4665

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4665

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4665

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4665

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4665

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4665

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4665

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4665

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4665

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4665

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4665

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4665

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4665

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4665

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4665

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4665

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4665

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4665

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4665

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4665

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4665

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4665

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4665

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4665

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4665

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4665

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4665

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4665

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4665

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4665

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4665

commit: 6233165

Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test in e2e/react-start/server-functions.

Name it "merge-server-fn-middleware-context".

@jamongsalguclub
Copy link
Contributor Author

Please add a test in e2e/react-start/server-functions.

Name it "merge-server-fn-middleware-context".

added E2E testing!

@schiller-manuel
Copy link
Contributor

sorry but this is not a server-function related issue.
could you please create a new server-routes e2e project next to server-functions by duplicating it, renaming it and stripping out the server-functions test, then move the new test into that.
also please then do the same for solid-start.

@SeanCassiere
Copy link
Member

Yup, Manuel's change makes sense 👍🏼

@jamongsalguclub
Copy link
Contributor Author

Thanks for the feedback! I've created new server-routes e2e projects for both React Start and Solid Start by duplicating the existing server-functions projects, removing the server-functions specific tests, and adding the middleware context merging test. The test has been moved from the server-functions spec to the new server-routes specs.

@nlynzaad
Copy link
Contributor

nlynzaad commented Jul 17, 2025

Hi we just pushed a change in how ports are determined for the e2e tests. in your new tests please add an await in front of the derive port call in playwright.config.ts

export const PORT = await derivePort(packageJson.name)
const baseURL = `http://localhost:${PORT}`

@jamongsalguclub
Copy link
Contributor Author

Thanks for your help!

@SeanCassiere SeanCassiere merged commit 1930152 into TanStack:main Jul 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServerRoute middleware chain context not merged but replaced
4 participants