Skip to content

feat: add solid devtools panel export to solid devtools #9551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 12, 2025
Merged

feat: add solid devtools panel export to solid devtools #9551

merged 5 commits into from
Aug 12, 2025

Conversation

AlemTuzlak
Copy link
Contributor

solid-devtools don't export the panel, added a panel export as well

@AlemTuzlak
Copy link
Contributor Author

I'm having local issues in getting the dev env to run:
image
any idea what this is about?

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9c0fad5

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 3s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-12 12:25:23 UTC

@TkDodo
Copy link
Collaborator

TkDodo commented Aug 11, 2025

can you check the failing lint and knip errors please

@AlemTuzlak
Copy link
Contributor Author

@TkDodo Oscar fixed the issues, should be ready for review now

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 12, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9551

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9551

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9551

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9551

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9551

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9551

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9551

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9551

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9551

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9551

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9551

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9551

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9551

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9551

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9551

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9551

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9551

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9551

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9551

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9551

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9551

commit: 9c0fad5

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.00%. Comparing base (6402d75) to head (9c0fad5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9551       +/-   ##
===========================================
- Coverage   45.18%   10.00%   -35.19%     
===========================================
  Files         208        4      -204     
  Lines        8319       50     -8269     
  Branches     1879       14     -1865     
===========================================
- Hits         3759        5     -3754     
+ Misses       4113       37     -4076     
+ Partials      447        8      -439
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oscartbeaumont
Copy link
Contributor

The code coverage issues seems to be coming from the React Query Devtools. The only changes this PR makes to that package is reexporting DevtoolsPanelOptions so it matches the Solid package. We didn't touch any runtime logic so I assume this must have been an issue already in main?

@TkDodo TkDodo merged commit c63713f into TanStack:main Aug 12, 2025
6 of 7 checks passed
@oscartbeaumont oscartbeaumont deleted the feat/add-solid-devtools-panel branch August 12, 2025 13:13
@TkDodo
Copy link
Collaborator

TkDodo commented Aug 12, 2025

no idea, codecov is pretty broken and I don’t really use it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query-devtools package: solid-query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlemTuzlak @TkDodo @oscartbeaumont