Skip to content

test(react-query/useIsFetching): remove unnecessary 'advanceTimersByTimeAsync', unify to 'rendered', and add detailed 'expect' for custom queryClient and state updates during rendering #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Aug 4, 2025

No description provided.

Copy link

nx-cloud bot commented Aug 4, 2025

View your CI Pipeline Execution ↗ for commit ccbb330

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 22s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-09 16:08:28 UTC

@sukvvon sukvvon marked this pull request as draft August 4, 2025 16:45
Copy link

pkg-pr-new bot commented Aug 4, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9530

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9530

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9530

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9530

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9530

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9530

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9530

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9530

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9530

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9530

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9530

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9530

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9530

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9530

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9530

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9530

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9530

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9530

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9530

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9530

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9530

commit: ccbb330

…imeAsync', unify to 'rendered', and add detailed 'expect' for custom queryClient and state updates during rendering
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.38%. Comparing base (95db48b) to head (ccbb330).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9530       +/-   ##
===========================================
+ Coverage   45.18%   84.38%   +39.19%     
===========================================
  Files         208       26      -182     
  Lines        8319      365     -7954     
  Branches     1879      107     -1772     
===========================================
- Hits         3759      308     -3451     
+ Misses       4113       48     -4065     
+ Partials      447        9      -438     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query 95.95% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sukvvon sukvvon force-pushed the test/react-query-useIsFetching-remove-unnecessary-advanceTimersByTimeAsync-unify-to-rendered-add-detailed-expect-for-custom-queryClient-and-state-updates branch from 5fb38e9 to 0ca2d44 Compare August 4, 2025 16:46
@sukvvon sukvvon marked this pull request as ready for review August 4, 2025 16:49
sukvvon added 2 commits August 9, 2025 19:52
…ssary-advanceTimersByTimeAsync-unify-to-rendered-add-detailed-expect-for-custom-queryClient-and-state-updates
…ssary-advanceTimersByTimeAsync-unify-to-rendered-add-detailed-expect-for-custom-queryClient-and-state-updates
@manudeli manudeli merged commit 77e53b0 into TanStack:main Aug 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants