Skip to content

feature(angular-query): support providing QueryClient via InjectionToken #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

feature(angular-query): support providing QueryClient via InjectionToken #9128

merged 1 commit into from
May 8, 2025

Conversation

arnoud-dv
Copy link
Collaborator

@arnoud-dv arnoud-dv commented May 8, 2025 •
edited
Loading

This is useful for example in thin app shell applications where feature teams provide their dependencies on lazy loaded route providers while still allowing to easily share a QueryClient.

This way the main bundle for the app shell does not include TanStack Query.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3c80b58.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 16s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-08 19:48:49 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 8, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9128

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9128

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9128

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9128

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9128

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9128

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9128

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9128

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9128

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9128

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9128

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9128

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9128

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9128

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9128

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9128

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9128

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9128

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9128

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9128

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9128

commit: 3c80b58

@arnoud-dv arnoud-dv force-pushed the feature/angular-lazy-load-queryclient branch 2 times, most recently from 7ff5920 to 972256f Compare May 8, 2025 19:41
@arnoud-dv arnoud-dv force-pushed the feature/angular-lazy-load-queryclient branch from 972256f to 3c80b58 Compare May 8, 2025 19:45
@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (8f092f9) to head (3c80b58).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9128       +/-   ##
===========================================
+ Coverage   44.55%   86.28%   +41.72%     
===========================================
  Files         207       17      -190     
  Lines        8159      328     -7831     
  Branches     1830       79     -1751     
===========================================
- Hits         3635      283     -3352     
+ Misses       4081       40     -4041     
+ Partials      443        5      -438
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 85.43% <100.00%> (+0.38%) ⬆️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnoud-dv arnoud-dv merged commit 57251a4 into TanStack:main May 8, 2025
7 checks passed
@arnoud-dv arnoud-dv deleted the feature/angular-lazy-load-queryclient branch May 8, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arnoud-dv