Refactor: Improve maintainability of WebpageImpact plugin #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several changes to enhance the maintainability, robustness, and clarity of the WebpageImpact plugin: - README: I corrected the description of the `duration` output metric to accurately reflect its behavior (measures execution time). - Constants: I replaced magic numbers related to default viewport dimensions and scroll behavior parameters with named constants for better readability and easier modification. - Logging: I enhanced logging in `mergeCdpData` by consolidating warnings for resources missing transfer sizes into a single message, reducing log noise. - Robustness: I added a timeout mechanism to the `scrollToBottomOfPage` function to prevent indefinite execution on very long or slow-loading pages, logging a warning if the timeout is reached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several changes to enhance the maintainability, robustness, and clarity of the WebpageImpact plugin:
durationoutput metric to accurately reflect its behavior (measures execution time).mergeCdpDataby consolidating warnings for resources missing transfer sizes into a single message, reducing log noise.scrollToBottomOfPagefunction to prevent indefinite execution on very long or slow-loading pages, logging a warning if the timeout is reached.