Skip to content

fix missing inlines in various headers and incorrect pointers in 'from_variable' #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2025

Conversation

thiago-carneiro
Copy link
Contributor

This pull request resolves two key issues:

  • Missing inline Specifiers:
    Several standalone function definitions in header files were missing the inline specifier. Since these functions are not member functions defined inside a class body, nor constexpr or template functions, they are not automatically given inline linkage by the compiler. Adding the inline specifier prevents multiple definition errors when these headers are included in multiple translation units.

  • Incorrect Pointer Usage in from_variable:
    The from_variable function previously accessed array data using .data(), which could result in incorrect memory offsets when handling sliced variables with non-zero origins. This has been corrected to use byte_strided_origin_pointer().get(), ensuring proper handling of array origins and memory layout.

@BrianMichell BrianMichell added the bug Something isn't working label Aug 6, 2025
Copy link
Collaborator

@BrianMichell BrianMichell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper clang formatting was holding the CI/CD pipeline back. Fixed.

@BrianMichell BrianMichell merged commit 2becd7a into TGSAI:main Aug 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants