fix missing inlines in various headers and incorrect pointers in 'from_variable' #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves two key issues:
Missing
inline
Specifiers:Several standalone function definitions in header files were missing the
inline
specifier. Since these functions are not member functions defined inside a class body, norconstexpr
or template functions, they are not automatically given inline linkage by the compiler. Adding theinline
specifier prevents multiple definition errors when these headers are included in multiple translation units.Incorrect Pointer Usage in
from_variable
:The
from_variable
function previously accessed array data using.data()
, which could result in incorrect memory offsets when handling sliced variables with non-zero origins. This has been corrected to usebyte_strided_origin_pointer().get()
, ensuring proper handling of array origins and memory layout.