Skip to content

[Experiment] Hide ULX command messages #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2023
Merged

[Experiment] Hide ULX command messages #9

merged 2 commits into from
Dec 15, 2023

Conversation

adamnejm
Copy link
Contributor

Hides ULX command messages, eg. !whip ^ 10 while still retaining ULX FancyLog messages, ie. You whipped Yourself 10 times with 0 damage.

Derpius
Derpius approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@Derpius Derpius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I don't know enough about ULib to say that it's valid. Will be checked in QA though

@Derpius
Copy link
Member

Derpius commented Dec 15, 2023

QA Result: Passed ✅

  • Chat messages for commands are not shown ✅
  • Logs from commands are still shown ✅

I noticed some commands are missing a log (well, only freeze and unfreeze from testing). Don't think this is a blocker though.

@Derpius Derpius merged commit 55174b1 into TAServers:master Dec 15, 2023
@adamnejm adamnejm mentioned this pull request Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derpius Derpius Derpius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
TAS Review Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamnejm @Derpius