Refactor nadmod_ppfriends to not use ReadTable #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Derpius wants to merge 1 commit into master from fix-netmsg-crash

Member

Derpius commented Feb 25, 2024

Issue

No issue

Changes

Rewrites the client -> server nadmod_ppfriends flow to not use net.ReadTable

Impact

Should fix a crash where an invalid type ID is spammed by a client
Significantly lower network footprint and easier to understand logic

Testing

No regressions to friends behaviour
Spamming a malformed nadmod_ppfriends netmsg does not crash the server
- I haven't had time to test this myself. Assuming net overflow limits kick in this should be fine

Helpful Links


          Refactor nadmod_ppfriends to not use ReadTable

ed3de24

Derpius requested a review from a team as a code owner

February 25, 2024 11:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet