Update minio to 2021-09-09T21-37-07Z #4683
Conversation
There was a problem hiding this comment.
I'm not sure about SERVICE_WIZARD_SHARE at the moment.
I tried to implement this in #4627. But as kiwix is a new package and does not have to use the folder by the service, this was an easy job. (see new Makefile variable SERVICE_WIZARD_SHARE_NAME and mk/spksrc.service.mk).
But there will be some effort to get the full path of the share for DSM < 7.
Only DSM7 creates a link for shared folders under /var/packages/{package}/shares/{share-name}.
For DSM < 7 we must use the synoshare CLI tool to evaluate the full path for a shared folder by share-name.
Hopefully there is no special handling for package upgrade required.
I'm going to wait until there is a working example merged before starting a different approach because I don't have access to a DSM7 device for testing. |
|
Any news on how to continue concerning SERVICE_WIZARD_SHARE? |
see #4748 (almost ready to merge) |
|
something is wrong with this PR: there are tons of non-related master branch changes pulled into this PR, it needs cleaning-up. Here's how I normally update my PR branch:
|
|
@th0ma7 Thanks for your help. I've already noticed I messed something up but did not have the time to clean it up yet. |
fgma
force-pushed
the
minio-2021-05-22
branch
from
c99c371 to
bea93a4
Compare
|
@th0ma7 Rebasing it again fixed the problem. I hope to get the rest done soon. |
fgma
changed the title
fgma
changed the title
|
I've upgraded minio to the latest release and changed the wizard similar to transmission. Currently the following issues are open:
|
|
@fgma I gave it a shot on master, on my new PR #4854 (contains a few parallel build fixes) and from your branch on your clone and I can't reproduce your issue. I've simply added a trace in As such, |
|
I test it against a clean checkout of master: This results in the following log: After adding the log message as suggested nothing changes: |
fgma
force-pushed
the
minio-2021-05-22
branch
from
36eff02 to
10e5869
Compare
|
I've upgraded minio to the latest release. Currently the following issues are open:
Can anyone provide some feedback on this? |
|
@hgy59 @ymartin59 Would be great if I could get some feedback so we can get this PR done soon. No problem if your lacking the time at the moment I just want make sure this PR is not forgotten. |
By experience that is due to an error somewhere in your code, often a |
|
For me the upgrade does not work at all The same spk works for a fresh installation. |
The log file |
- adjust license - derive tag from PKG_VERS - increment SPK_REV
fgma
force-pushed
the
minio-2021-05-22
branch
from
1bd55b2 to
1c4a4ee
Compare
|
Thanks a lot for you fast help! I tried to get the update ready but messed something up during rebase because I wanted to build against the new go version. This should be fixed now. If there are no issues left feel free to merge this anytime you like. Until then I will updated this PR with the latest minio release. |
hgy59
added
the
status/published
* minio: fix SPK_VERS for DSM7 * minor fixes - adjust license - derive tag from PKG_VERS - increment SPK_REV * Fix spk/minio/src/wizard/upgrade_uifile.sh * minio: updated to 2021-09-18T18-09-59Z * minio: update wizard to select volume from combobox * minio: upgrade to latest release and change verion number scheme * minio: fix PKG_VERS * minio: add license file to package Co-authored-by: fgma <[email protected]> Co-authored-by: hgy59 <[email protected]>
Motivation: Update minio to 2021-06-14T01-29-23Z and prepare for DSM7.
Linked issues: #4524
Depends on #4655 being merged first to compile.
Checklist
all-supportedcompleted successfullyChecklist DSM 7
I'm not sure about SERVICE_WIZARD_SHARE at the moment.