Skip to content

Append timestamp to stdout and stderr logs and config flags #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nirmalc
Copy link

@nirmalc nirmalc commented Dec 19, 2013

Append timestamp to stdout and stderr logs and config flagsthis uses 'asctime' internal - dict value to append timestamp to stdout , stderr logs.

%s_append_timestamp enables/disables this feature per process.

@kespindler
Copy link

Is there a status on this PR? Looks like there was an issue with Travis. Would like to use this feature.

@nirmalc
Copy link
Author

nirmalc commented Jul 24, 2014

I think travis issue was with python version

@kespindler
Copy link

Looking at supervisor's Travis, it looks like it doesn't run on python2.5 any more. (And moreover, it's running diff versions through tox.) I admit I'm new to the Travis stuff.

Could this commit be rebased on top of origin/master, a new PR opened, and have that trigger what looks like are new Travis settings? I can try this out on my own branch if you're not set up for this.

@nirmalc
Copy link
Author

nirmalc commented Jul 24, 2014

Thanks - I'll do that today.

@mnaberez
Copy link
Member

Looking at supervisor's Travis, it looks like it doesn't run on python2.5 any more.

The current release version of Supervisor is 3.0. It supports Python 2.4+ but not Python 3. On the 3.0 branch, we can't test all the Pythons we support on Travis and Tox, but we do what those tools support.

The master branch will become Supervisor 4.0. It will support Python 2.6+ and 3.2+. Most of the recent work on Supervisor has been towards Python 3 compatibility.

(And moreover, it's running diff versions through tox.) I admit I'm new to the Travis stuff.

On the master branch, Tox and Travis should be testing the same versions, and we are even running Tox inside Travis to do it.

New code needs to run on 2.6+ and 3.2+.

@mnaberez
Copy link
Member

@nirmalc Thanks for this patch. It's important for us to add test coverage for any new features we add. If you would be willing to write some tests for this, we would consider it for inclusion. We might want to call this option "prepend" since it does not append.

@nirmalc
Copy link
Author

nirmalc commented Jul 24, 2014

Thanks - I wil work on tests as well and change name as suggested.

@yuanaichi
Copy link

thx

@mnaberez
Copy link
Member

mnaberez commented Feb 17, 2015

I'm going to close this due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants