Add eslint-plugin-astro #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lint astro.build files.
kaste
reviewed
Feb 27, 2025
linter.py
Outdated
| @@ -38,6 +38,7 @@ | |||
|
|
|||
| STANDARD_SELECTOR = 'source.js, source.jsx' | |||
| PLUGINS = { | |||
| 'eslint-plugin-astro': 'source.astro, text.html.astro, meta.template.astro, text.html.markdown.jsx', | |||
There was a problem hiding this comment.
Generally, I think this is the right approach. However, I don't know how you've come to these selectors. I think it's only source.astro; at least that's what The Astro package you linked defines. Usually you only want the outermost or base scope. Basically, the first part of the scope if the cursor is in (0, 0) position.
There was a problem hiding this comment.
I used Ctrl+Shift+P and then the "copy" command. I've removed the others beyond source.astro
Remove extra scopes.
|
Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building an astro website and would like to have it linted using
https://github.com/ota-meshi/eslint-plugin-astro
I think that this might also be required: https://packagecontrol.io/packages/Astro
So maybe this isn't the correct way to do this.
In which case, what is the correct way to do this?