Everything is on fire (major github feature update)

[SEAPUNK]

GitHub just now updated everything, including a new profile page, projects, etc.

https://github.com/blog/2256-a-whole-new-github-universe-announcing-new-tools-forums-and-features

[xt0rted]

These are a couple pages with issues now

• https://github.com/xt0rted
• https://github.com/xt0rted/Nancy.Validation.DataAnnotations.Extensions/projects
• https://github.com/xt0rted/Nancy.Validation.DataAnnotations.Extensions/projects/1

[spidersouris]

https://developer.github.com/early-access/platform-roadmap/ too

[Mottie]

OMG it burns! LOL

Yeah, I think I might just add some quick patches to fix the big things, but now might be a good time to maybe start over to get rid of all the obsolete selectors in this style.

@silverwind how do you think we should organize the style? I remember you didn't like having everything split up like it is now.

[ddavison]

#404 Issue Not Found.

(sorry, had to)

[ebramanti]

@ddavison You beat me to it 👌

[SEAPUNK]

#404 style not found, more like

[silverwind]

start over

We could start a branch for a rewrite from scratch with only the selectors that apply and with @-moz-document scopes for each site. I estimate it will take a few weeks to finish. In the meanwhile, let's do some short-term fixes for the recent changes.

[Mottie]

Working on it now

[joubertredrat]

/* new usernav on profile */
.user-profile-nav {
    background-color: transparent !important;
}

.user-profile-sticky-bar::after {
    background-color: #181818 !important;
}

Fixed new navbar on profile, worked here.
-- edit
tomorrow night theme

[Mottie]

Hmm, I was going to make the .user-profile-nav also have a #181818 background, but I think your idea is better.

[Mottie]

Nope, it needs to be #181818.

[silverwind]

Yeah, sounds better to have it go to the header-color once it stickies. BTW, I wouldn't mind dropping the sticky positioning later, similar to what I've done on the diff sticky [1].

[1]

GitHub-Dark/github-dark.css

Lines 266 to 270 in d2d82ec

	/* HACK: Disable useless position:sticky on PR diffs */
	.pr-toolbar.is-stuck {
	position: static !important;
	margin-top: -20px !important;
	}

[silverwind]

Inline discussion sample: nodejs/node#8519 (diff)

[Mottie]

Thanks