Fix some issues in test_10_82_3 #24
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this fixes a few issues:
ptpPatternpreviously allowed lowercase hex digits, but the ABNF in RFC 7273 uses RFC 5234HEXDIG, which only accepts uppercase.ptpPatternpreviously accepted the pre-RFC 7273 errata form forptp-domain-name. (The resolution deletes thedomain-name=prefix, similarly to theptp-domain-nmbrcase, which is already correct in this test.)ptp-domain-nameform is in any case only used for IEEE 1588-2002 (v1), not 2008 (v2), so isn't necessary for ST 2110-10.traceableABNF, the message about supported PTP versions needed updating.$to the end of the regex, which means the check for!ptpMatch[4] && ptpDetails.endsWith(':')is no longer required since that case will be caught by the earlier one (!ptpPattern.test(ptpDetails.slice(14)))domainNmbrerror could have fired before, sinceptpMatch[4]includes the colon, so+ptpMatch[4]would always have been zero. I've changed this toptpMatch[5].