Skip to content

Conversation

@ianshade
Copy link
Contributor

No description provided.

@danjenkins
Copy link

@ianshade tried to add your fork using yarn add ianshade/grandiose and got this error

gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  COPY ../build/Release/libndi.4.dylib
  CXX(target) Release/obj.target/grandiose/src/grandiose_util.o
../src/grandiose_util.cc:48:5: error: use of undeclared identifier 'itoa'
    itoa(errorInfo->error_code, errorCode, 10), errorInfo->error_message);
    ^
../src/grandiose_util.cc:92:23: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  for ( int x = 0 ; x < argc ; x++ ) {
                    ~ ^ ~~~~
../src/grandiose_util.cc:134:43: error: use of undeclared identifier 'itoa'
    status = napi_create_string_utf8(env, itoa(c->status, errorChars, 10),
                                          ^
1 warning and 2 errors generated.
make: *** [Release/obj.target/grandiose/src/grandiose_util.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2

@Julusian Julusian merged commit 11a3e5d into Streampunk:master Jan 7, 2023
@Julusian
Copy link
Collaborator

Julusian commented Jan 7, 2023

This has been merged as part of #18.
While it may need more work, as its a new area I think it acceptable to merge it now and refine it as it gets more tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants