Adding support for ADCIRCS v56.1.0 and v56.2.1#1656
Draft
Conversation
Collaborator
Author
|
Resolves #1545 |
Resolves #1545.
Collaborator
Author
|
@jasonfleming Here are the changes to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to test. @jasonfleming note that there is a necessary patch for
src/adcirc.Fin v56.1.0's patch-set; v56.2.1 doesn't have it, presumably this was one of the things they fixed. However I didn't yet look at my fix versus theirs.We need to test these on all of our supported machines, I will keep it a draft until we figure out what to do about the
adcirc.Fpatch for v56.1.0.Testing needs to be done across a representative sampling machines and all compilers (intel classic, intel oneAPI, GCC).