Skip to content

Tests: Improve stability for AbortOnConnectFailTests #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2025

Conversation

NickCraver
Copy link
Collaborator

These had a lot timeout for runtime due to a shared method for faster test execution but in the day but the success case should be fast but worst case it should not fail - we'd much rather it occasionally take a second than fail the test suite and add noise to the process.

These had a lot timeout for runtime due to a shared method for faster test execution but in the day but the success case _should_ be fast but worst case it should not fail - we'd much rather it occasionally take a second than fail the test suite and add noise to the process.
Fixes a few issues and transitions us to WSL2 underneath - let's see how this works
@NickCraver
Copy link
Collaborator Author

NickCraver commented Jul 29, 2025

@mgravell I'm tinkering here, but check out https://github.com/StackExchange/StackExchange.Redis/runs/46946456491#r0s34

Note the error from IllegalCombinations presented in BasicTranWithHashExistsCondition - they do not share a multiplexer, but would share a socket worker pool...

StackExchange.Redis.Tests.SortedSetWhenTest ► SortedSetWhenTest.IllegalCombinations (RESP2)

Failed test found in:
  test-results/_pkrvmpptgkbjq6m_2025-07-29_13_12_06.trx
Error:
  Assert.Throws() Failure: No exception was thrown
  Expected: typeof(StackExchange.Redis.RedisServerException)
StackExchange.Redis.Tests.TransactionTests ► TransactionTests.BasicTranWithHashExistsCondition(demandKeyExists: False, keyExists: True, expectTranResult: False) (RESP2)

Failed test found in:
  test-results/_pkrvmpptgkbjq6m_2025-07-29_13_12_06.trx
Error:
  StackExchange.Redis.RedisServerException : ERR GT, LT, and/or NX options at the same time are not compatible

@NickCraver
Copy link
Collaborator Author

@mgravell Did you see comment above?

@mgravell
Copy link
Collaborator

The impossible mismatched results? Yes, which inspired me to do some more work on ripping out the IO core. Something is seriously borked.

@NickCraver NickCraver marked this pull request as ready for review August 2, 2025 18:56
@NickCraver NickCraver merged commit 8fffdff into main Aug 2, 2025
9 of 11 checks passed
@NickCraver NickCraver deleted the craver/tests/abort-connect-stability branch August 2, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants