hocon: fix round-tripping of extraneous comment indent#449
Merged
zml2008 merged 7 commits intoSpongePowered:masterfrom Nov 11, 2023
Merged
hocon: fix round-tripping of extraneous comment indent#449zml2008 merged 7 commits intoSpongePowered:masterfrom
zml2008 merged 7 commits intoSpongePowered:masterfrom
Conversation
jpenilla
force-pushed
the
hocon-comment-roundtripping
branch
from
a30ea32 to
e132bac
Compare
Member
|
This looks like it should be a good improvement, what are you thinking still needs to happen before this is undrafted? |
jpenilla
force-pushed
the
hocon-comment-roundtripping
branch
from
e132bac to
741d372
Compare
Contributor
Author
|
Probably could have undrafted it earlier, rebased now though Is it intentional that -vendor tests don't run on ci? I checked that typesafe-configs passed locally fwiw |
Member
|
That is not intentional I don't think, could use a |
zml2008
approved these changes
Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Hexaoxide/Carbon#311 properly