Skip to content

hocon: setup vendor project, remove config sorting on write and use order preserving collections#446

Merged
zml2008 merged 9 commits intoSpongePowered:masterfrom
jpenilla:patched-hocon
Nov 9, 2023
Merged

hocon: setup vendor project, remove config sorting on write and use order preserving collections#446
zml2008 merged 9 commits intoSpongePowered:masterfrom
jpenilla:patched-hocon

Conversation

@jpenilla
Copy link
Copy Markdown
Contributor

@jpenilla jpenilla commented Nov 8, 2023

No description provided.

@jpenilla jpenilla force-pushed the patched-hocon branch 3 times, most recently from 3346c6f to 27f0078 Compare November 8, 2023 05:57
@zml2008
Copy link
Copy Markdown
Member

zml2008 commented Nov 9, 2023

looking at your to do list and thinking a bit more, I think it's ok to disable key sorting entirely -- if users wanted keys to be sorted they could change the map factory in the ConfigurationOptions itself

@jpenilla jpenilla changed the title hocon: setup vendor project and add option to not sort configs hocon: setup vendor project, remove config sorting on write and use order preserving collections Nov 9, 2023
@jpenilla jpenilla marked this pull request as ready for review November 9, 2023 05:10
@zml2008
Copy link
Copy Markdown
Member

zml2008 commented Nov 9, 2023

tyty!!!

@zml2008 zml2008 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into SpongePowered:master with commit 53201ee Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants