-
Notifications
You must be signed in to change notification settings - Fork 31
Add tamil translation #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ananthb is attempting to deploy a commit to the Spedon's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the PR! I have a question tho, have you tested the font capability? If I remember correctly, only CJK and latin fonts are provided. |
|
Yep. Just added a tamil font that should work. |
|
Is the 'Threshold' a lower bound or an upper bound? It works better in Tamil if that's defined. |
|
Ah so it's the cursor move threshold for loading images. How do you feel about adding a title attribute to the threshold |
|
Like this: ananthb@749abf4 |
this is a breaking change since all i18n files need to update, maybe create another pr?
Is it a sans serif font? If not would you mind post a picture about it, thanks |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sounds good.
I switched to this one just now: https://fonts.google.com/noto/specimen/Noto+Sans+Tamil. I found the version labelled Noto Sans Tamil, so I'm using that one now.
|
LGTM, can merge it after you add tamil to README.md |
|
Done! |


No description provided.