Skip to content

Conversation

@ananthb
Copy link
Contributor

@ananthb ananthb commented Dec 26, 2024

No description provided.

@vercel
Copy link

vercel bot commented Dec 26, 2024

@ananthb is attempting to deploy a commit to the Spedon's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Sped0n0ld
Copy link
Contributor

Sped0n0ld commented Dec 26, 2024

Thanks for the PR!

I have a question tho, have you tested the font capability? If I remember correctly, only CJK and latin fonts are provided.

@ananthb
Copy link
Contributor Author

ananthb commented Dec 28, 2024

Yep. Just added a tamil font that should work.

@ananthb
Copy link
Contributor Author

ananthb commented Dec 28, 2024

Is the 'Threshold' a lower bound or an upper bound? It works better in Tamil if that's defined.

@ananthb
Copy link
Contributor Author

ananthb commented Dec 28, 2024

Ah so it's the cursor move threshold for loading images.

How do you feel about adding a title attribute to the threshold <span> describing what it does?

@ananthb
Copy link
Contributor Author

ananthb commented Dec 28, 2024

Like this: ananthb@749abf4

@Sped0n0ld
Copy link
Contributor

Sped0n0ld commented Dec 29, 2024

Ah so it's the cursor move threshold for loading images.

How do you feel about adding a title attribute to the threshold <span> describing what it does?

this is a breaking change since all i18n files need to update, maybe create another pr?

Yep. Just added a tamil font that should work.

Is it a sans serif font? If not would you mind post a picture about it, thanks

@vercel
Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridget ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 11:35am

@ananthb
Copy link
Contributor Author

ananthb commented Dec 30, 2024

this is a breaking change since all i18n files need to update, maybe create another pr?

Sounds good.

Is it a sans serif font? If not would you mind post a picture about it, thanks

I switched to this one just now: https://fonts.google.com/noto/specimen/Noto+Sans+Tamil.
I was using a Noto font labeled serif, but I don't think it actually makes a difference in Tamil.

I found the version labelled Noto Sans Tamil, so I'm using that one now.

Screenshot 2024-12-30 at 20 33 55

@Sped0n0ld
Copy link
Contributor

this is a breaking change since all i18n files need to update, maybe create another pr?

Sounds good.

Is it a sans serif font? If not would you mind post a picture about it, thanks

I switched to this one just now: https://fonts.google.com/noto/specimen/Noto+Sans+Tamil. I was using a Noto font labeled serif, but I don't think it actually makes a difference in Tamil.

I found the version labelled Noto Sans Tamil, so I'm using that one now.

Screenshot 2024-12-30 at 20 33 55

LGTM, can merge it after you add tamil to README.md

@ananthb
Copy link
Contributor Author

ananthb commented Jan 2, 2025

Done!

@Sped0n0ld Sped0n0ld merged commit 9016cfb into Sped0n:main Jan 3, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants