[BED-6067] Add isReadOnlyDC property to computer objects

[definitelynotagoblin]

Description

Add isReadOnlyDC property to Computer objects, determined from UAC attribute.

Motivation and Context

BED-6067

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Documentation updates are needed, and have been made accordingly.
• I have added and/or updated tests to cover my changes.
• All new and existing tests passed.
• My changes include a database migration.

Summary by CodeRabbit

• New Features

  • Added a new property to indicate if a computer is a read-only domain controller.

• Tests

  • Updated unit tests to verify the presence and value of the new property.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new boolean property, IsReadOnlyDC, was added to the Computer class to indicate read-only domain controller status. The LDAP property processor was updated to populate this property based on the UserAccountControl flag. Corresponding test assertions were added to verify the new property in unit tests.

Changes

File(s)	Change Summary
src/CommonLib/OutputTypes/Computer.cs	Added IsReadOnlyDC boolean property to the Computer class.
src/CommonLib/Processors/LdapPropertyProcessor.cs	Updated ReadComputerProperties to include "isreadonlydc" in the properties dictionary.
test/unit/LdapPropertyTests.cs	Added assertions for the "isreadonlydc" property in the relevant unit test.

Poem

In the warren of code, a new flag appears,
To spot read-only DCs, and calm admin fears.
The processor checks, the tests all agree,
A hop for each property, as clear as can be.
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/CommonLib/OutputTypes/Computer.cs (1)

22-22: Add XML‐doc comment for public API surface

Every public property on our DTOs is currently documented.
Please add a short <summary> so downstream code-gen and API consumers pick it up.

-        public bool IsReadOnlyDC { get; set; }
+        /// <summary>
+        /// True when the computer account represents a Read-Only Domain Controller (RODC)
+        /// </summary>
+        public bool IsReadOnlyDC { get; set; }

test/unit/LdapPropertyTests.cs (1)

467-476: Missing positive test for RODC detection

We only assert the negative case (false).
Please add a second fixture with UserAccountControl |= 0x4000000 (PartialSecretsAccount) and assert that "isreadonlydc" is true to prevent regressions.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ad304b and 2c2350e.

📒 Files selected for processing (3)

• src/CommonLib/OutputTypes/Computer.cs (1 hunks)
• src/CommonLib/Processors/LdapPropertyProcessor.cs (1 hunks)
• test/unit/LdapPropertyTests.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (1)

src/CommonLib/Processors/LdapPropertyProcessor.cs (1)

355-360: isreadonlydc flag added – verify it propagates to the final Computer instance

Good catch adding the flag.
Double-check that whatever code maps ComputerProperties.Props → Computer sets IsReadOnlyDC from this new dictionary key; otherwise the new field will never reach the serialized output.

#!/bin/bash
# Locate any mapping code that copies props["isreadonlydc"] to Computer.IsReadOnlyDC
rg -i --context 2 $'isreadonlydc"' | head