Kube-Series-1: Features/prometheus metrics #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 13, 2019 13:14
… properly manage "Accept: text/plain" header in requests
…dded WebServer config to allow secondary port on tomcat and fix Spring Actuator login page redirection failure
Crim
reviewed
Dec 14, 2019
Crim
reviewed
Dec 14, 2019
...a-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/configuration/WebServerConfig.java
Outdated
Show resolved
Hide resolved
bygui86
changed the title
Crim
reviewed
Dec 15, 2019
|
Looking good so far! |
|
Is there a problem on my side? |
|
Code wise seems fine. Looks like CI is failing because of some checkstyle rules: I think that class needs a class level javadoc, likely explaining that it manages securing the actuator end points behind http basic auth? |
|
Done and pushed! |
|
Yeah!! Ready to merge Kube-Series-Part-1!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go with step 1 of the series "Kafka WebView on Kubernetes"
@Crim please review