Skip to content

SQSCANGHA-84 Remove outdated wget/curl references#248

Merged
henryju merged 1 commit into
masterfrom
worktree-SQSCANGHA-84-wget-busybox
Jun 4, 2026
Merged

SQSCANGHA-84 Remove outdated wget/curl references#248
henryju merged 1 commit into
masterfrom
worktree-SQSCANGHA-84-wget-busybox

Conversation

@henryju

@henryju henryju commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Ticket SQSCANGHA-84: wget --no-verbose failing on Busybox — the original bug no longer exists since the action was refactored to use Node.js (@actions/tool-cache) for downloads, which doesn't use wget or curl at all
  • Remove curl/wget and unzip from the self-hosted runner prerequisites in the README (not needed by the Node.js action); add a note that gpg/dirmngr can be skipped with skipSignatureVerification: true
  • Rename three QA test jobs that had misleading wget/curl-specific names — they test URL injection prevention and redirect handling, which are mechanism-agnostic

Test plan

  • QA gate passes with the renamed job IDs
  • README prerequisites section is accurate for self-hosted runner users

🤖 Generated with Claude Code

The action was refactored to use Node.js (@actions/tool-cache) for
downloads, which doesn't rely on wget or curl. Update the README and
QA workflow to reflect this.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 4, 2026

Copy link
Copy Markdown

SQSCANGHA-84

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@gitar-bot

gitar-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Removes outdated wget, curl, and unzip prerequisites from the README and updates QA job names to reflect their purpose. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henryju henryju merged commit c9d327c into master Jun 4, 2026
77 checks passed
@henryju henryju deleted the worktree-SQSCANGHA-84-wget-busybox branch June 4, 2026 15:25
luketainton pushed a commit to luketainton/repos_epage-go that referenced this pull request Jun 9, 2026
…(#12)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v8.1` → `v8.2` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v8.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.2.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.2.0...v8.2.0)

#### What's Changed

- SQSCANGHA-149 Add scannerBinariesAuthHeader input by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;246](SonarSource/sonarqube-scan-action#246)
- SQSCANGHA-88 Deprecate the SONARCLOUD\_URL env variable support by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;249](SonarSource/sonarqube-scan-action#249)
- SQSCANGHA-84 Remove outdated wget/curl references by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;248](SonarSource/sonarqube-scan-action#248)
- SQSCANGHA-135 Fix scanner binaries always re-downloaded due to incompatible 4-part version by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;250](SonarSource/sonarqube-scan-action#250)
- SQSCANGHA-127 Rename downloaded file to .zip before extraction on Windows by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;251](SonarSource/sonarqube-scan-action#251)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v8...v8.2.0>

### [`v8.2`](SonarSource/sonarqube-scan-action@v8.1.0...v8.2.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.1.0...v8.2.0)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMTYuMiIsInVwZGF0ZWRJblZlciI6IjQzLjIxNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/epage-go/pulls/12
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton pushed a commit to luketainton/repos_roboluke that referenced this pull request Jun 9, 2026
…(#455)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [SonarSource/sonarqube-scan-action](https://github.com/SonarSource/sonarqube-scan-action) | action | minor | `v8.1` → `v8.2` |

---

### Release Notes

<details>
<summary>SonarSource/sonarqube-scan-action (SonarSource/sonarqube-scan-action)</summary>

### [`v8.2.0`](https://github.com/SonarSource/sonarqube-scan-action/releases/tag/v8.2.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.2.0...v8.2.0)

#### What's Changed

- SQSCANGHA-149 Add scannerBinariesAuthHeader input by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;246](SonarSource/sonarqube-scan-action#246)
- SQSCANGHA-88 Deprecate the SONARCLOUD\_URL env variable support by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;249](SonarSource/sonarqube-scan-action#249)
- SQSCANGHA-84 Remove outdated wget/curl references by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;248](SonarSource/sonarqube-scan-action#248)
- SQSCANGHA-135 Fix scanner binaries always re-downloaded due to incompatible 4-part version by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;250](SonarSource/sonarqube-scan-action#250)
- SQSCANGHA-127 Rename downloaded file to .zip before extraction on Windows by [@&#8203;henryju](https://github.com/henryju) in [#&#8203;251](SonarSource/sonarqube-scan-action#251)

**Full Changelog**: <SonarSource/sonarqube-scan-action@v8...v8.2.0>

### [`v8.2`](SonarSource/sonarqube-scan-action@v8.1.0...v8.2.0)

[Compare Source](SonarSource/sonarqube-scan-action@v8.1.0...v8.2.0)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMTYuMiIsInVwZGF0ZWRJblZlciI6IjQzLjIxNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/455
Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk>
Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants