SQSCANGHA-146 Add proxy support for GPG keyserver access#242
Conversation
SummaryThis PR adds automatic proxy detection for GPG keyserver access, enabling signature verification to work transparently in corporate proxy-restricted environments. What changed:
Key design decision: Only What reviewers should knowStart here: Review the core logic in
Test coverage:
Things to verify:
|
489001c to
113d1c8
Compare
|
|
We would also be interested in having this merged. Alternatively, an analogous setting to scannerBinariesUrl for the GPG Key. Thanks @m4s-b3n for fixing! |
|
Hi, I flagged this internally for review. Thanks for your patience. |
|
I applied some changes in a separate branch, please follow #244 Thanks for your contribution |
|
Released as part of v8.1.0 |



Add proxy support for GPG keyserver access
Motivation
When the action runs on self-hosted runners behind a corporate proxy, GPG signature verification fails because
gpg --recv-keyscannot reach the keyserver. This change makes the GPG key import step automatically pick up the standard proxy environment variables (HTTPS_PROXY,https_proxy) so that signature verification works transparently in proxy-restricted environments.Changes
src/main/gpg-verification.js– AddedgetProxyFromEnv()helper and wired it intotryImportKey()via--keyserver-options http-proxy=….src/main/__tests__/gpg-verification-mocked.test.js– Added tests forgetProxyFromEnv(5 tests) and proxy propagation intryImportKey(6 tests).README.md– Added a note in theskipSignatureVerificationsection mentioning automatic proxy detection.dist/– Rebuilt bundle.Checklist