-
Notifications
You must be signed in to change notification settings - Fork 709
SONARJAVA-5534 Remove SE engine and unused duplicated check test sources #5176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARJAVA-5534 Remove SE engine and unused duplicated check test sources #5176
Conversation
its/plugin/tests/src/test/java/com/sonar/it/java/suite/PackageInfoTest.java
Outdated
Show resolved
Hide resolved
2cc820d to
eff2529
Compare
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor comments about unnecessary changes to new lines at the end of a few files.
We discussed the change offline. I verified that everything removed looks related to symbolic execution.
| "hasTruePositives": true, | ||
| "falseNegatives": 7, | ||
| "falsePositives": 0 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change here is a new line at the end of the file. We should avoid such changes as part of this PR (they are okay if there are other changes to the file).
| "hasTruePositives": true, | ||
| "falseNegatives": 4, | ||
| "falsePositives": 0 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change.
| "hasTruePositives": false, | ||
| "falseNegatives": 0, | ||
| "falsePositives": 0 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change
| "hasTruePositives": false, | ||
| "falseNegatives": 0, | ||
| "falsePositives": 0 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change
| "hasTruePositives": false, | ||
| "falseNegatives": 0, | ||
| "falsePositives": 0 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change
|





No description provided.