Skip to content

Conversation

@alban-auzeill
Copy link
Member

No description provided.

@alban-auzeill alban-auzeill force-pushed the alban-remix/remove-unused-test-sources branch from 2cc820d to eff2529 Compare May 30, 2025 08:06
@alban-auzeill alban-auzeill changed the title SONARJAVA-5534 Remove SE engine and unused duplicated check test sources [DO NOT MERGE, Alban Remix version] SONARJAVA-5534 Remove SE engine and unused duplicated check test sources May 30, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comments about unnecessary changes to new lines at the end of a few files.

We discussed the change offline. I verified that everything removed looks related to symbolic execution.

"hasTruePositives": true,
"falseNegatives": 7,
"falsePositives": 0
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here is a new line at the end of the file. We should avoid such changes as part of this PR (they are okay if there are other changes to the file).

"hasTruePositives": true,
"falseNegatives": 4,
"falsePositives": 0
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change.

"hasTruePositives": false,
"falseNegatives": 0,
"falsePositives": 0
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change

"hasTruePositives": false,
"falseNegatives": 0,
"falsePositives": 0
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change

"hasTruePositives": false,
"falseNegatives": 0,
"falsePositives": 0
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change

@sonarqube-next
Copy link

@alban-auzeill alban-auzeill merged commit 4765a65 into master May 30, 2025
15 of 16 checks passed
@alban-auzeill alban-auzeill deleted the alban-remix/remove-unused-test-sources branch May 30, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants