Skip to content

Conversation

@mikee47
Copy link
Contributor

@mikee47 mikee47 commented Sep 13, 2025

Issue #2971 revealed a problem with the task queue where the onReady callback never gets called.
The callback gets queued but the event loop is created afterwards and lacked a 'kick' to the tcpip thread to start message processing.

This bug has been present since PR #2913.

@what-the-diff
Copy link

what-the-diff bot commented Sep 13, 2025

PR Summary

  • Introduced New Function for Message Handling
    A new function named tcpip_kick_thread() has been added. This contains logic that was present in system_os_post() as it is now also called from start_sming_task_loop().

  • Enhanced Documentation
    The documentation has been updated with comments for newly introduced functions, these include: tcpip_kick_thread() and tcpip_message_handler(). This addition makes the purpose of these functions more understandable to others.

  • Incorporation of tcpip_kick_thread() in Message Queuing
    The start_sming_task_loop() function now uses tcpip_kick_thread(). This means that when the task loop begins, it will also handle any messages that are in the queue.

@mikee47
Copy link
Contributor Author

mikee47 commented Sep 14, 2025

@slaff The CI failures in jerryscript really need it updating to a more recent version. I'm prepping v3 for that, will have a PR for you shortly.

@slaff slaff added this to the 6.2.0 milestone Sep 15, 2025
Messages can be queued before task loop initialised,
so kick tcpip thread when it is
@slaff slaff merged commit 10cf967 into SmingHub:develop Sep 16, 2025
35 checks passed
@mikee47 mikee47 deleted the fix/esp32-tasks branch September 17, 2025 08:42
@slaff slaff mentioned this pull request Dec 16, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants