-
Notifications
You must be signed in to change notification settings - Fork 63
Feature/robot config gearing #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The bottom two sections are more semantically distinct than the top (i.e. I wanted to emphasize that the theoretical panel is not using the values in the motor calculator) |
src/document/RobotConfigStore.ts
Outdated
| asSolverRobotConfig(): SavedRobotConfig & { | ||
| wheelMaxTorque: number; | ||
| wheelMaxVelocity: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are you trying to do here? Are you pulling robot config and a couple? I see that in the drive motor section of the robot config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulling robot config, adding the two computed properties, and omitting the motor torque, motor velocity, and gearing. The result gets sent to rust.
src/document/RobotConfigStore.ts
Outdated
| export const ROBOT_CONFIG_DEFAULTS = { | ||
| mass: LbsToKg(150), | ||
| rotationalInertia: 6, | ||
| motorMaxVelocity: MotorCurves.KrakenX60.motorMaxVelocity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistent defaults




No description provided.