Skip to content

Conversation

@Awesomeplayer165
Copy link
Collaborator

No description provided.

@Awesomeplayer165
Copy link
Collaborator Author

Awesomeplayer165 commented Jan 2, 2024

Make the text wrap under paths to avoid a scrollview

image

@shueja shueja marked this pull request as ready for review January 3, 2024 23:56
@shueja shueja requested review from Lyssia-Seiden and shueja January 5, 2024 01:34
@Awesomeplayer165
Copy link
Collaborator Author

Awesomeplayer165 commented Jan 5, 2024

why is there a divider on bottom but not top

image

Also, be consistent with dividers. The vertical doesn't look the same as the horizontal rules.

@shueja
Copy link
Collaborator

shueja commented Jan 5, 2024

The bottom two sections are more semantically distinct than the top (i.e. I wanted to emphasize that the theoretical panel is not using the values in the motor calculator)

@Awesomeplayer165
Copy link
Collaborator Author

Awesomeplayer165 commented Jan 5, 2024

did you change icon sizes? They look a bit big and off-centered

image

@Awesomeplayer165
Copy link
Collaborator Author

What are my path settings here? I don't see any settings, but waypoints. Do you suggest that waypoints and obstacles are settings of the path? This might get confusing..

image

Comment on lines 110 to 112
asSolverRobotConfig(): SavedRobotConfig & {
wheelMaxTorque: number;
wheelMaxVelocity: number;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are you trying to do here? Are you pulling robot config and a couple? I see that in the drive motor section of the robot config.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulling robot config, adding the two computed properties, and omitting the motor torque, motor velocity, and gearing. The result gets sent to rust.

export const ROBOT_CONFIG_DEFAULTS = {
mass: LbsToKg(150),
rotationalInertia: 6,
motorMaxVelocity: MotorCurves.KrakenX60.motorMaxVelocity,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent defaults

@shueja shueja merged commit 69d6c04 into main Jan 5, 2024
@shueja shueja deleted the feature/robot-config-gearing branch January 5, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants