Skip to content

Conversation

@shueja
Copy link
Collaborator

@shueja shueja commented Dec 7, 2023

If the promise failed in the step before generation (the path validation), this would catch that failure and pass it as a success value as rust_traj and break a bunch of stuff. Users might not notice it but it makes a console error.

@shueja shueja merged commit 2e95789 into main Dec 20, 2023
@shueja shueja deleted the bugfix/redundant-generation-catch branch December 20, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants