Skip to content

Conversation

@r4stered
Copy link
Contributor

@r4stered r4stered commented Dec 5, 2023

#189

This adds the C++ version of choreolib to allow loading of trajectories and controlling a robot based on them.

@r4stered r4stered marked this pull request as ready for review December 5, 2023 18:59
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use wpiformat to format the C++ source code. See the .clang-format, .styleguide, .styleguide-license, and Actions workflows for TrajoptLib.

@calcmogul calcmogul added this to the 2024 Kickoff Release milestone Jan 4, 2024
@calcmogul
Copy link
Member

Idk why clang-tidy is being given an empty string.

@r4stered
Copy link
Contributor Author

r4stered commented Jan 4, 2024

Idk why clang-tidy is being given an empty string.

that is strange. because CI is passing on my fork?

@calcmogul
Copy link
Member

calcmogul commented Jan 4, 2024

That's because CI is only running clang-tidy on files changed from main (allwpilib does this because running clang-tidy on every file takes too long). You PRed from your main branch, so your fork isn't running clang-tidy on any files.

@calcmogul
Copy link
Member

Try running the commands locally. Double-check that compile_commands.json has stuff in it before and after the fix-up script.

@r4stered
Copy link
Contributor Author

r4stered commented Jan 4, 2024

Try running the commands locally. Double-check that compile_commands.json has stuff in it before and after the fix-up script.

Chaning tidy-changed to tidy-all, I am getting the same error. I do see the compile commands json has content. Will investigate

wpiformat -no-format -tidy-changed -compile-commands=build/TargetedCompileCommands/linuxx86-64release -vv

@calcmogul
Copy link
Member

calcmogul commented Jan 4, 2024

If you can't figure it out, I'd accept disabling the clang-tidy job for now via if: false, with a comment in the .yml explaining why.

@calcmogul calcmogul linked an issue Jan 4, 2024 that may be closed by this pull request
@calcmogul calcmogul merged commit 962dceb into SleipnirGroup:main Jan 4, 2024
@calcmogul calcmogul changed the title C++ ChoreoLib Add C++ port of ChoreoLib Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Choreolib C++ support

2 participants