-
Notifications
You must be signed in to change notification settings - Fork 63
Add C++ port of ChoreoLib #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calcmogul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use wpiformat to format the C++ source code. See the .clang-format, .styleguide, .styleguide-license, and Actions workflows for TrajoptLib.
choreolib/src/main/native/cpp/choreo/lib/ChoreoSwerveCommand.cpp
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/cpp/choreo/lib/ChoreoSwerveCommand.cpp
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/cpp/choreo/lib/ChoreoTrajectoryState.cpp
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/cpp/choreo/lib/ChoreoTrajectoryState.cpp
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/cpp/choreo/lib/ChoreoTrajectoryState.cpp
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectoryState.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectoryState.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectory.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectory.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectory.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectory.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoTrajectory.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/include/choreo/lib/ChoreoSwerveCommand.h
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/cpp/choreo/lib/ChoreoTrajectoryState.cpp
Outdated
Show resolved
Hide resolved
choreolib/src/main/native/cpp/choreo/lib/ChoreoTrajectoryState.cpp
Outdated
Show resolved
Hide resolved
|
Idk why clang-tidy is being given an empty string. |
that is strange. because CI is passing on my fork? |
|
That's because CI is only running clang-tidy on files changed from main (allwpilib does this because running clang-tidy on every file takes too long). You PRed from your main branch, so your fork isn't running clang-tidy on any files. |
|
Try running the commands locally. Double-check that compile_commands.json has stuff in it before and after the fix-up script. |
Chaning tidy-changed to tidy-all, I am getting the same error. I do see the compile commands json has content. Will investigate |
|
If you can't figure it out, I'd accept disabling the clang-tidy job for now via |
#189
This adds the C++ version of choreolib to allow loading of trajectories and controlling a robot based on them.