File saving overhaul: Write files immediately w/ error passback, loud feedback on saving. #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: ui
calcmogul
approved these changes
Apr 20, 2025
Tinbite-A
pushed a commit
to Tinbite-A/Choreo-Bunnybots-2025MD
that referenced
this pull request
Nov 13, 2025
… feedback on saving. (SleipnirGroup#1221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of reliability issues with our file writing system, this reverts to debounced immediate asynchronous save calls. This gives the option for result pass-back when saving is completed. That is used in a new autosave indicator. For the .chor, the indicator is next to the Undo/Redo buttons. For the .traj, the saving feedback is integrated into the path list icon.
Also, the main menu now shows the local time-string of the last project autosave.
In Rust,
ChoreoResult.trace_err()andtrace_warn()now pass through the error for further use.There's lots of dead code to remove if this PR proves to be more reliable while retaining usability/performance.
To test:
Use Choreo as normal, keeping watch for saving indicators acting upon changes, and check that progress is being saved appropriately.