[choreolib] AutoChooser Fixes and Sim behavior changes #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The |
Going from disconnected to auto in sim will quick load the auto
oh-yes-0-fps
changed the title
selected getter and added .instance for elastic
shueja
reviewed
Dec 21, 2024
|
|
||
| // private final StringEntry selected, active; | ||
| // private final StringArrayEntry options; | ||
| private int allianceId = -1; |
Collaborator
Author
There was a problem hiding this comment.
For easier comparison
Contributor
There was a problem hiding this comment.
What is wrong with using .equals() with the return value of DriverStation.getAlliance()? As per Optional's documentation:
Indicates whether some other object is "equal to" this Optional. The other object is considered equal if:
- it is also an Optional and;
- both instances have no value present or;
- the present values are "equal to" each other via equals().
shueja
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changing alliance while disabled re-evaluate command creator
Makes going from disconnect->auto in sim quick load the auto then run it
Prevents a crash from composition going between enabled and disconnected
Fix an issue with
selectedin the sendables api being set when it shouldn'tAdded
.instanceto work with elastic