-
-
Notifications
You must be signed in to change notification settings - Fork 103
Update shared infra and fix styles #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update shared infra and fix styles #387
Conversation
We'll need to fix the build on main first (by copying some build config from ImageSharp) |
And this project was still on net6 |
* removed the configure method. thats only syntactic sugar and aot is not happy with that method
I have updated this lib to .net8 and .net9. I had to fix some issues which were reported. The configure method was complaining multiple things because of aot. Because this is just a lil bit of syntactic sugar i went with deleting it |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
===================================
Coverage 85% 85%
===================================
Files 82 82
Lines 2343 2348 +5
Branches 350 351 +1
===================================
+ Hits 2012 2019 +7
+ Misses 230 228 -2
Partials 101 101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon. |
I was not happy about that dynamicaccessedattributes either. Those are probably from enabled aot. We could also go the way of removing them and add istrimmable = false. |
No description provided.