Skip to content

Update shared infra and fix styles #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stefannikolei
Copy link
Contributor

No description provided.

@JimBobSquarePants
Copy link
Member

We'll need to fix the build on main first (by copying some build config from ImageSharp)

@stefannikolei
Copy link
Contributor Author

We'll need to fix the build on main first (by copying some build config from ImageSharp)

And this project was still on net6

* removed the configure method. thats only syntactic sugar and aot is not happy with that method
@stefannikolei
Copy link
Contributor Author

I have updated this lib to .net8 and .net9. I had to fix some issues which were reported.

The configure method was complaining multiple things because of aot. Because this is just a lil bit of syntactic sugar i went with deleting it

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85%. Comparing base (46068c2) to head (0c2c992).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...Sharp.Web/Commands/QueryCollectionRequestParser.cs 0% 1 Missing ⚠️
...rc/ImageSharp.Web/Processors/ResizeWebProcessor.cs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #387   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        82     82           
  Lines      2343   2348    +5     
  Branches    350    351    +1     
===================================
+ Hits       2012   2019    +7     
+ Misses      230    228    -2     
  Partials    101    101           
Flag Coverage Δ
unittests 85% <89%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JimBobSquarePants
Copy link
Member

@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon.

@stefannikolei
Copy link
Contributor Author

@stefannikolei I need to have a good look at this as I'm not happy with all the new required attributes. Will try my best to get on it soon.

I was not happy about that dynamicaccessedattributes either.

Those are probably from enabled aot.

We could also go the way of removing them and add istrimmable = false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants