Skip to content

Common Logger Initialisation Improvements #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

kashyap-thacker
Copy link
Collaborator

@kashyap-thacker kashyap-thacker commented Jul 14, 2023

Jira:

SEN-6542

Description:

Common Logger:

  • Allow initialising with custom handler to flexibility to add file handlers and formatters for local logging.
  • Utils to create handlers and formatters

Misc:

  • Added Git Pull Request template

Type of change:

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist (put x in bracket to check):

Please do not delete options here.

  • I have performed a self-review of my code
  • Existing unit tests pass locally with my changes
  • I have written coverage for new code
  • I have updated the Production deployment sheet if this service required production changes in this sprint

Copy link

@vikas010 vikas010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..

@kashyap-thacker kashyap-thacker merged commit cbc6c95 into main Jul 14, 2023
@kashyap-thacker kashyap-thacker deleted the SEN-6542-generic-logger branch July 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants