upgrade for purescript 0.10 #25
Conversation
| @@ -10,24 +10,14 @@ import Control.Monad.Eff.Exception | |||
|
|
|||
| import Data.Argonaut (printJson) | |||
| import Data.Argonaut.Core (Json(..)) | |||
| import Data.Argonaut.Decode (DecodeJson, decodeJson) | |||
| -- import Data.Argonaut.Decode (DecodeJson, decodeJson) | |||
There was a problem hiding this comment.
Since these examples are broken and I've basically converted all the examples into test cases, do you think we still need them?
We could just add a link to Readme.MD, saying "please check out the tests for more examples?"
There was a problem hiding this comment.
Yeah, I think that's a good idea!
| = "ok" := boolToJsNumber w.success | ||
| ~> "n" := w.total | ||
| ~> "nInserted" := fromMaybe 0.0 w.inserted | ||
| ~> "nModified" := fromMaybe 0.0 w.modified |
There was a problem hiding this comment.
👍 Awesome, I noticed this was broken as well.
There was a problem hiding this comment.
Thanks :)
BTW, I have a question: I used 0.0 here instead of 0 because WriteResult takes Maybe Number, and 0 is a Int not a Number. But I don't understand why I can't create a Number by (0 :: Number), it doesn't typecheck. That's why I used 0.0. The same trick I used here
There was a problem hiding this comment.
I think that's purescript works.
| liftEff $ log "should update" | ||
| col <- collection "events" database | ||
| res <- updateOne ["name" B.:= "Wow"] ["name" B.:= "lol"] defaultUpdateOptions col | ||
| liftEff $ assert $ (obj [ "ok" A.:= 1, "n" A.:= 1, "nModified" A.:= 1, "nInserted" A.:= 0]) == (encodeJson res) |
There was a problem hiding this comment.
Didn't know you could do that with infixed symbols.
There was a problem hiding this comment.
I don't like this actually.
res here is a WriteResult, to verify it, It's better to construct another WriteResult then compare. But I can't take this approach, because the constructor of WriteResult is not exported.
That's why I used this workaround here which will encode the WriteResult into Json, then create another Json to compare. I don't like it because it's testing two functions together: insertOne + encodeJson.
What do you think? Is there better pattern for asserting the result?
There was a problem hiding this comment.
Probably is, but let's leave it for now.
|
Examples have been removed, and Readme.md has been updated @SimonRichardson could you take a second look? |
|
🎉 Congratulations and thanks for the time! |
|
Cool. Thanks for reviewing my PR |
Could you review my PR @SimonRichardson ?