Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3383e57 to
25c4d1b
Compare
Contributor
|
Claude finished @manika-signoz's task in 2m 5s —— View job Review: Admonition Standardisation
SummaryThe refactor is well-structured — typed props, CVA variants, theme map, and Issues Found
Additional Notes
Checklist items not yet verified in the PR
|
75837e9 to
fc73624
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/SigNoz/engineering-pod/issues/3397
Rebuilds the docs Admonition component with SigNoz-themed styling, typed props, size variants (
sm/lg), and a collapsible header (chevron toggle, optionaldefaultCollapsed). Removes the standalone KeyPointCallout component and maps the existing<KeyPointCallout />MDX tag to Admonition for backwards compatibility.Motivation / Problem
Current Admonitions did not align with designs.
Figma - https://www.figma.com/design/eyORbfrXMWCz9w0xEFdgWe/Periscope-%E2%80%93-Primitives-v2?node-id=12-749&p=f&m=dev
Changes
components/Admonition/Admonition.tsxto a client component: theme map per kind (note,tip,warning,danger,info,important, default), CVA-based variants,cn/class-variance-authority, Tailwindnot-proseand nestedcode/prestyling.defaultCollapsedsupports boolean or string"true"/"false".components/KeyPointCallout/KeyPointCallout.tsx; incomponents/MDXComponents.tsx, registerKeyPointCalloutas a thin wrapper aroundAdmonitionwith defaulttitle/typewhen omitted.Description
This PR replaces the old admonition UI with a token-aligned, accessible callout card. KeyPointCallout is no longer a separate component file; MDX that still uses
<KeyPointCallout>renders through Admonition so existing guides and OpenTelemetry docs do not need a bulk tag rename.Type of Change
data/docs/**data/blog/**app/**,components/**,hooks/**,utils/**, config, etc.next.config.jsredirectsImpact
If breaking change, describe migration steps:
<KeyPointCallout>and<Admonition>remain valid MDX components; visual appearance and behavior (collapsible header) change.Context & Screenshots
visuals only for all types

Before / After (if applicable)
/blog/celery-worker - default

/blog/opentelemetry-demo/ - KeyPointCallout replaced

/docs/huggingface-observability/ - Admonition important type

/docs/huggingface-observability/ - KeyPointCallout default collapsed

/docs/ai/signoz-mcp-server/ - Admonition warning type

/docs/aws-monitoring/sqs/ - Admonition tip type

Checklist
General
maintype: description)For all changes
yarn build) with no errorsyarn lintand fixed any issuesyarn check:doc-redirects/yarn check:docs-metadataif applicable)For docs changes (
data/docs/**)constants/docsSideNav.tsif adding or moving a docpublic/img/docs/<topic>/For blog changes
title,date,author,tags(andcanonicalUrlif applicable)public/img/blog/<YYYY-MM>/For site code changes
For renamed or moved docs
next.config.jsunderasync redirects()constants/docsSideNav.tsyarn check:doc-redirectsto verifyTesting
Note: Submit as Draft by default. Mark "Ready for review" when checks pass and content is ready.