Properly reset state after leaving a regex capture#3970
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
the
server
Graphite App
st0012
approved these changes
Feb 20, 2026
Merge activity
|
### Motivation We were supposed to set the regexp capture state back to false when leaving the node, not set it to true again. Otherwise, we fail to highlight local variable target nodes that appear after the regex. ### Implementation Just switched to `false`. ### Automated Tests Added a test that reproduces.
graphite-app
bot
force-pushed
the
02-20-properly_reset_state_after_leaving_a_regex_capture
branch
from
2b3c328 to
409dea2
Compare
graphite-app
bot
deleted the
02-20-properly_reset_state_after_leaving_a_regex_capture
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We were supposed to set the regexp capture state back to false when leaving the node, not set it to true again. Otherwise, we fail to highlight local variable target nodes that appear after the regex.
Implementation
Just switched to
false.Automated Tests
Added a test that reproduces.