`test-unit` reporter causes large performance degradation

[Earlopain]

When I run a test class via "Run in Terminal", I can see how long these tests take. With a normal invocation, the tests finish in ~5 seconds, if the test-unit is reported the duration doubles to about 10 seconds.

I guess this does not happen so extremely in every scenario, just when the test file contains many tests. Specifically I encounter this in the prism snapshots test which creates about 3000 individual test methods. https://github.com/ruby/prism/blob/main/test/prism/snapshots_test.rb

$ bundle exec ruby -r/home/user/.rbenv/versions/3.4.6/lib/ruby/gems/3.4.0/gems/ruby-lsp-0.26.4/lib/ruby_lsp/test_reporters/test_unit_reporter.rb -Itest /home/user/code/ruby-prism/test/prism/snapshots_test.rb --testcase "/^Prism::SnapshotsTest\$/" --name "/\$/"
Loaded suite /home/user/code/ruby-prism/test/prism/snapshots_test
Started
Finished in 10.048171088 seconds.
--------------------------------------------------------------------------------------------------------------------------
2894 tests, 5788 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------------------------------------------------
288.01 tests/s, 576.03 assertions/s

$ bundle exec ruby  -Itest /home/user/code/ruby-prism/test/prism/snapshots_test.rb --testcase "/^Prism::SnapshotsTest\$/" --name "/\$/"
Loaded suite /home/user/code/ruby-prism/test/prism/snapshots_test
Started
Finished in 5.454402877 seconds.
--------------------------------------------------------------------------------------------------------------------------
2894 tests, 5788 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
--------------------------------------------------------------------------------------------------------------------------
530.58 tests/s, 1061.16 assertions/s

Attached there is a vernier profile. I see the custom reporter at about 18% runtime. That's not quite the 50% I would be expecting based on runtime but still quite a lot:

time_profile.json (view on https://vernier.prof)

[vinistock]

Thanks for the report. The implementation only invokes the original code through super and then writes the result to the socket that we use to communicate with the extension (code). My suspicion is that the tests run so fast IO becomes the bottleneck.

We could try to change the LspReporter to never write to IO immediately, but instead push items to a queue and have a dispatcher thread that writes them as IO becomes unblocked.

[github-actions]

This issue is being marked as stale because there was no activity in the last 2 months

[alexcrocha]

Thanks again for reporting. We addressed this in #3962 by decoupling the reporter's IO from test execution. If the issue persists after the next release, feel free to re-open and we can investigate further.