Skip to content

Visit filter kwargs in Variable::ParseTreeVisitor #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Visit filter kwargs in Variable::ParseTreeVisitor #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/liquid/variable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,14 @@ def evaluate_filter_expressions(context, filter_args, filter_kwargs)
end

class ParseTreeVisitor < Liquid::ParseTreeVisitor
def children_filter(filter)
nodes = [filter[0], *filter[1]]
nodes.concat(filter[2].values) if filter[2]
nodes
end

def children
[@node.name] + @node.filters.flatten
[@node.name] + @node.filters.flat_map { |filter| children_filter(filter) }
end
end
end
Expand Down
6 changes: 3 additions & 3 deletions test/unit/parse_tree_visitor_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ def test_variable
)
end

def test_varible_with_filter
def test_variable_with_filter
assert_equal(
["test", "infilter"],
visit(%({{ test | split: infilter }})),
["test", "infilter", "infilter_hash_value"],
visit(%({{ test | default: infilter, allow_false: infilter_hash_value }})),
)
end

Expand Down