typeerror in node version 4 and lower verison

[gabyidong]

if(utf8read(corpus) == utf8readb(corpus)) utf8read = utf8readb;
var utf8readc = function utf8readc(data) { return Buffer.from(data, 'binary').toString('utf8'); };
if(utf8read(corpus) == utf8readc(corpus)) utf8read = utf8readc;

Buffer.from(data, 'binary') 
TypeError: binary is not a function
    at Function.from (native)
    at Function.from (native)
    at repl:1:8
    at REPLServer.defaultEval (repl.js:252:27)
    at bound (domain.js:287:14)
    at REPLServer.runBound [as eval] (domain.js:300:12)
    at REPLServer.<anonymous> (repl.js:417:12)
    at emitOne (events.js:82:20)
    at REPLServer.emit (events.js:169:7)
    at REPLServer.Interface._onLine (readline.js:211:10)

[SheetJSDev]

What node version are you using? According to the last test run https://travis-ci.org/SheetJS/js-xlsx/builds/386754693 this worked in 0.8.x, 0.10.x, 0.12.x and 4.x (there's also a test run for each major version 5-10)

[gabyidong]

@SheetJSDev ,my node version is 4.4.3

[SheetJSDev]

So I can reproduce in node 4.0.0-4.4.7, but it seems to have been fixed in 4.5.0.

The NodeJS CHANGELOG https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V4.md#4.5.0 suggests that the PR nodejs/node#7562 fixed the problem in between versions.

We had to make the shift to Buffer.from (used to be new Buffer) because node 10 decided to add a deprecation warning :( .

This issue does not affect 0.12.x because the code falls back on a Buffer.from shim. It also does not affect the 6.x or 8.x or 10.x series.

Are you able to upgrade to 4.5.0+ or should we add a version check?

[gabyidong]

@SheetJSDev ，thanks ，but i can't decide the version on the production environment. let me think it

[SheetJSDev]

We're slowly updating the related projects @gabyidong .

Summary: Buffer.from had a different interface in node versions 4.0.x - 4.4.x. Unfortunately Buffer.from is non-writable, so we can't just assign to it like we can in 0.12 and lower.

In the dependencies, we've fixed this by making a separate Buffer_from variable, and we will be doing the same here